Repository navigation
[ML] Adds title elements which were missing from Calendars pages - #33257
Merged
peteharverson merged 3 commits intoMar 15, 2019
Merged
Conversation
peteharverson
requested review from
alvarezmelissa87,
jgowdyelastic and
walterra
March 14, 2019 17:16
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
alvarezmelissa87
approved these changes
Mar 14, 2019
alvarezmelissa87
left a comment
Contributor
There was a problem hiding this comment.
Just a small comment but other than that LGTM
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 15, 2019
…stic#33257) * [ML] Adds title elements which were missing from Calendars pages * [ML] Removed use of arrow function in calendar list header * [ML] Updated calendar list header snapshot
peteharverson
added a commit
that referenced
this pull request
Mar 15, 2019
) (#33310) * [ML] Adds title elements which were missing from Calendars pages * [ML] Removed use of arrow function in calendar list header * [ML] Updated calendar list header snapshot
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 18, 2019
…stic#33257) * [ML] Adds title elements which were missing from Calendars pages * [ML] Removed use of arrow function in calendar list header * [ML] Updated calendar list header snapshot
peteharverson
added a commit
that referenced
this pull request
Mar 18, 2019
#33257) (#33311) * [ML] Adds title elements which were missing from Calendars pages (#33257) * [ML] Adds title elements which were missing from Calendars pages * [ML] Removed use of arrow function in calendar list header * [ML] Updated calendar list header snapshot * [7.0] [ML] Update snapshot for calendar list header test
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…stic#33257) * [ML] Adds title elements which were missing from Calendars pages * [ML] Removed use of arrow function in calendar list header * [ML] Updated calendar list header snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds title elements which were missing from the Calendar Settings pages (list page and create calendar page).
This clarifies to the user what settings are being viewed / edited, and also makes the pages consistent with the Filter Lists settings pages.
A brief summary of the Calendars functionality, and a refresh button have also been added to the list page, consistent with the Filter Lists page.
Checklist
For maintainers
Fixes #32757