Repository navigation
[ML] Replace View Forecast button image with Single Metric icon - #34563
Merged
peteharverson merged 2 commits intoApr 5, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui |
snide
reviewed
Apr 4, 2019
| @@ -2,31 +2,20 @@ | |||
| .forecasts-table { | |||
Contributor
There was a problem hiding this comment.
Just a reminder. This doesn't look needed. Might want to just look into using the compressed prop on the table.
Contributor
Author
There was a problem hiding this comment.
Good spot @snide. I have replaced the two forecast table scss files with JS props on the table. Can you take another look please.
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
alvarezmelissa87
left a comment
Contributor
There was a problem hiding this comment.
Latest changes LGTM @peteharverson
snide
approved these changes
Apr 5, 2019
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Apr 5, 2019
…tic#34563) * [ML] Replace View Forecast button image with Single Metric icon * [ML] Remove table scss overrides and use icon in Explorer view
peteharverson
added a commit
that referenced
this pull request
Apr 5, 2019
…) (#34639) * [ML] Replace View Forecast button image with Single Metric icon * [ML] Remove table scss overrides and use icon in Explorer view
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…tic#34563) * [ML] Replace View Forecast button image with Single Metric icon * [ML] Remove table scss overrides and use icon in Explorer view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
EuiButtonwith the Font Awesomefa-line-charticon with anEuiButtonIconusing astatsicon for the 'View forecast' link to the Single Metric Viewer. This makes it consistent with the control used to link to the Single Metric Viewer used for annotations and for the result view links in the Jobs Management page.Also adds extra information to the
aria-labelfor the button, adding the 'created date' to help identify which forecast the button is linking to, as used by screen readers.Before:
After:
Also switches out the
popouticon used to open the Single Metric Viewer from anomalies in the Anomaly Explorer to thestatsicon for consistency:Checklist
For maintainers