Repository navigation
[InfraUI] [LogsUI] Autocomplete Field: Increase suggestions limit and allow scrolling - #34706
Merged
Kerry350 merged 2 commits intoApr 11, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/infrastructure-ui |
Contributor
💚 Build Succeeded |
weltenwort
reviewed
Apr 10, 2019
weltenwort
left a comment
Member
There was a problem hiding this comment.
Simple and effective 👍 just one small suggestion below
…complete_field.tsx Co-Authored-By: Kerry350 <k.gallagher.05@gmail.com>
Contributor
Author
|
@weltenwort Thanks for the review, I've committed your change suggestion 👍 |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Apr 11, 2019
… allow scrolling (elastic#34706) * Autocomplete_field: Increase suggestions limit and allow scrolling * Update x-pack/plugins/infra/public/components/autocomplete_field/autocomplete_field.tsx Co-Authored-By: Kerry350 <k.gallagher.05@gmail.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
… allow scrolling (elastic#34706) * Autocomplete_field: Increase suggestions limit and allow scrolling * Update x-pack/plugins/infra/public/components/autocomplete_field/autocomplete_field.tsx Co-Authored-By: Kerry350 <k.gallagher.05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #34068 and #34069. As discussed this removes the results limit of 10 and allows scrolling. As this is a first solution, not implementing more complex solutions like virtualisation or server side pagination, I've still maintained a limit, but of 200 rather than 10, to ensure performance isn't massively degraded.
Testing
Try searching for something with a lot of results in the autocomplete bar and ensure scrolling works.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibility