Skip to content

[ML] Fix file data visualizer index pattern match - #34721

Merged
jgowdyelastic merged 2 commits into
elastic:masterfrom
jgowdyelastic:fix-file-data-viz-index-pattern-match
Apr 8, 2019
Merged

jgowdyelastic merged 2 commits into
elastic:masterfrom
jgowdyelastic:fix-file-data-viz-index-pattern-match

Conversation

@jgowdyelastic

Copy link
Copy Markdown
Member

When building the regex to check that the inputted index pattern matches the index, some special regex characters are replaced in the string.
These replacements need to be global to catch repeated characters.

Fixes #34720

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience :ml v8.0.0 v7.2.0 labels Apr 8, 2019
@jgowdyelastic jgowdyelastic self-assigned this Apr 8, 2019
@jgowdyelastic
jgowdyelastic requested a review from a team as a code owner April 8, 2019 15:14
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jgowdyelastic
jgowdyelastic merged commit aa78584 into elastic:master Apr 8, 2019
@jgowdyelastic
jgowdyelastic deleted the fix-file-data-viz-index-pattern-match branch April 8, 2019 15:57
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Apr 8, 2019
* [ML] Fix file data visualizer index pattern match

* also global replace . and +
jgowdyelastic added a commit that referenced this pull request Apr 8, 2019
* [ML] Fix file data visualizer index pattern match

* also global replace . and +

@alvarezmelissa87 alvarezmelissa87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* [ML] Fix file data visualizer index pattern match

* also global replace . and +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience :ml release_note:fix v7.2.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants