Repository navigation
[new-platform] Improve naming and consistency in Plugin types - #34725
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform |
joshdover
force-pushed
the
cleanup-dependency-naming
branch
from
April 8, 2019 16:06
1c68c59 to
a8b8d3f
Compare
Contributor
💚 Build Succeeded |
eliperelman
approved these changes
Apr 9, 2019
Contributor
💚 Build Succeeded |
rudolf
reviewed
Apr 9, 2019
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
rudolf
approved these changes
Apr 10, 2019
rudolf
left a comment
Contributor
There was a problem hiding this comment.
The last two dependency parameters aren't as critical as the public API, but would be nice to have these consistent too.
| * is the contract returned by the dependency's `setup` function. | ||
| */ | ||
| public async setup(setupContext: PluginSetupContext, dependencies: TDependenciesSetup) { | ||
| public async setup(setupContext: PluginSetupContext, dependencies: TPluginsSetup) { |
Contributor
There was a problem hiding this comment.
Not as critical as the public API, but probably worth making this dependency paramater consistent too
| * is the contract returned by the dependency's `setup` function. | ||
| */ | ||
| public async setup(setupContext: PluginSetupContext, dependencies: TDependenciesSetup) { | ||
| public async setup(setupContext: PluginSetupContext, dependencies: TPluginsSetup) { |
Contributor
There was a problem hiding this comment.
another dependency parameter
Contributor
💚 Build Succeeded |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Apr 10, 2019
joshdover
added a commit
that referenced
this pull request
Apr 10, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…c#34725) * Improve consistency in Plugin types * Use #has() instead of undefined check * Rename parameter * Update core docs * Internal updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves the naming and consistency of the types for the
PluginServices between the public and server versions.Plugininterface for server plugins.setupcan return a Promise for server plugins.