Repository navigation
[Canvas] Fixes esdocs fields - #34894
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas |
w33ble
approved these changes
Apr 10, 2019
w33ble
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
I think we can change API_ROUTE back to /api/canvas too. It seems to work and I don't see any interpreter requests that don't just use the library. If you don't want to do that here, please open an issue about it.
Contributor
|
|
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
cqliu1
force-pushed
the
fix/esdocs-fields
branch
from
April 10, 2019 22:49
d8f0688 to
c85b0f9
Compare
Contributor
💚 Build Succeeded |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Apr 12, 2019
* Fixed api route for esFields * Changes canvas api route back to /api/canvas
cqliu1
added a commit
that referenced
this pull request
Apr 12, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Fixed api route for esFields * Changes canvas api route back to /api/canvas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #34888.
The base path for the Canvas API was changed, but this route was hard coded to
/api/canvas. This updates the path to reference the constant variable for the API base path and fixes the field request for esdocs datasource form.This also changes
API_ROUTEback to/api/canvas/. This constant variable is only referenced inside of Canvas, and our API routes should read as/api/canvas/workpadinstead of/api/interpreter/workpad.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers