Repository navigation
[Uptime] Add new context for uptime - #34006
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/uptime |
Contributor
💚 Build Succeeded |
11 tasks
justinkambic
force-pushed
the
uptime_context
branch
2 times, most recently
from
April 6, 2019 05:49
2009c64 to
0c76aa4
Compare
Contributor
💔 Build Failed |
justinkambic
force-pushed
the
uptime_context
branch
from
April 8, 2019 17:17
0c76aa4 to
a9aa7f6
Compare
Contributor
💔 Build Failed |
justinkambic
force-pushed
the
uptime_context
branch
from
April 8, 2019 20:16
a9aa7f6 to
4c12627
Compare
Contributor
💔 Build Failed |
justinkambic
force-pushed
the
uptime_context
branch
from
April 8, 2019 22:29
4c12627 to
23065e2
Compare
Contributor
💚 Build Succeeded |
justinkambic
force-pushed
the
uptime_context
branch
from
April 9, 2019 14:03
23065e2 to
e4766b5
Compare
Contributor
💔 Build Failed |
justinkambic
force-pushed
the
uptime_context
branch
from
April 9, 2019 15:06
e4766b5 to
8a6f00a
Compare
Contributor
💔 Build Failed |
justinkambic
force-pushed
the
uptime_context
branch
from
April 9, 2019 18:25
8a6f00a to
47db0f6
Compare
Contributor
💚 Build Succeeded |
justinkambic
marked this pull request as ready for review
April 10, 2019 12:36
justinkambic
force-pushed
the
uptime_context
branch
from
April 11, 2019 15:58
6c08d63 to
f9dfa23
Compare
Contributor
💚 Build Succeeded |
… values displayed.
justinkambic
force-pushed
the
uptime_context
branch
from
April 11, 2019 18:56
7c945c3 to
a689288
Compare
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Apr 12, 2019
7 tasks
justinkambic
added a commit
that referenced
this pull request
Apr 12, 2019
Contributor
Author
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Add new context for uptime. * Implement Uptime context. * Convert application class to functional component. * Fix typings. * Fix busted types. * Update unit tests. * Move query files. Update API/functional tests. * Fix code formatting. * Fix improper import syntax. * Delete obsolete code. * Add base path to app context. * Add refresh tracker to app context. * Clean up code. * Fix unit conversion defect and add a unit test to check for incorrect values displayed. * Fix broken code formatting. * Clean up redundant code. * Split context into separate contexts for refresh and settings. * Fix unit test snapshot and props. * Fix code formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the initial version of Uptime, we had several fields that were shared from the top-level application component all the way down to the most nested component in the UI. This is exactly what contexts are designed for, so going forward we should make use of a context to avoid the need for sharing so many props and
& UptimeCommonPropseverywhere.The primary goals of this patch are as follows:
UptimeCommonPropsand the need to pass{...this.props}to so many child componentsUptimeContextto the UI to provide these important global valuesThis PR is WIP.Overview
There are 3 main changes in this PR:
*QuerycomponentsUptimeContextfor top-level global propsAdditionally, the GraphQL queries have been moved to a dedicated directory outside of the
componentsfolder.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers