Repository navigation
[Monitoring] Address shard allocation color mismatch - #34086
Merged
chrisronline merged 2 commits intoMar 28, 2019
Merged
chrisronline merged 2 commits into
chrisronline merged 2 commits into
Conversation
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
💚 Build Succeeded |
ycombinator
reviewed
Mar 28, 2019
| expect(component).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('should show UNASSIGNED non-primary shards', () => { |
Contributor
There was a problem hiding this comment.
Nit: non-primary is more commonly known as replica.
ycombinator
reviewed
Mar 28, 2019
| const component = shallow(<Shard {...props}/>); | ||
| expect(component).toMatchSnapshot(); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
How about adding test cases for the rest of the shard states for completeness?
Contributor
|
I have an unassigned replica shard. However, it's using the wrong color. It seems to be using the color of unassigned primary shards: |
Contributor
Author
|
Thanks @ycombinator. Nice find. I added tests and found another issue too. All fixed up and ready for another round |
Contributor
💚 Build Succeeded |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Mar 28, 2019
* Address mismatch and add a couple starter tests * More tests and fixing a bug
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Mar 28, 2019
* Address mismatch and add a couple starter tests * More tests and fixing a bug
chrisronline
added a commit
that referenced
this pull request
Mar 28, 2019
chrisronline
added a commit
that referenced
this pull request
Mar 28, 2019
Contributor
Author
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Apr 22, 2019
* Address mismatch and add a couple starter tests * More tests and fixing a bug
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Apr 22, 2019
* Address mismatch and add a couple starter tests * More tests and fixing a bug
chrisronline
added a commit
that referenced
this pull request
Apr 22, 2019
chrisronline
added a commit
that referenced
this pull request
Apr 22, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Address mismatch and add a couple starter tests * More tests and fixing a bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #31376
This PR fixes an issue where the actual shard listings didn't match the legend color scheme. I've added a couple simple tests for a couple scenarios, but would love to hear about potentially more important use cases to test against (most likely from @pickypg if he has the time).
@cachedout Do you know if we can get this into 7.0.0, or does it need to wait for 7.0.1?