Repository navigation
Allow non numeric fields in Top Hits in TSVB - #35661
Merged
Merged
Conversation
alexwizp
marked this pull request as ready for review
April 29, 2019 13:24
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
emmacunningham
approved these changes
Apr 29, 2019
emmacunningham
left a comment
There was a problem hiding this comment.
Tested locally and code LGTM, just a small comment
Contributor
💚 Build Succeeded |
sulemanof
reviewed
May 2, 2019
sulemanof
reviewed
May 2, 2019
sulemanof
approved these changes
May 2, 2019
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
May 2, 2019
* Allow non numeric fields in Top Hits in TSVB * fix build * fix pr comment
alexwizp
added a commit
that referenced
this pull request
May 2, 2019
|
Am facing this problem exactly with v7.4.2 and string fields. What did this issue fix in v7.2.0? |
|
Apparently, it didn't fix anything. I still see this restriction that the top-hits field must be numeric in filebeat 7.7. |
Contributor
|
Non-numeric fields are only allowed in table vis |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Allow non numeric fields in Top Hits in TSVB * fix build * fix pr comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #35353
Summary
Allow non numeric fields in Top Hits in TSVB
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers