Repository navigation
[ML] Add data-test-subj to some job management elements - #35284
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Apr 23, 2019
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Apr 23, 2019
pheyos
added a commit
that referenced
this pull request
Apr 23, 2019
pheyos
added a commit
that referenced
this pull request
Apr 23, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This PR adds a `data-test-subj` attribute with a descriptive value to the following elements of the ML job management page: - Create new job button - Refresh job list button - Job list filter bar - Jobs table - Delete job modal This will help locate these elements during UI automation more reliably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
data-test-subjattribute with a descriptive value to the following elements of the ML job management page:This will help locate these elements during UI automation more reliably.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately