Repository navigation
[Infra + Logs UI] Fix autocomplete overflow in Safari browser - #36820
Merged
weltenwort merged 1 commit intoMay 22, 2019
Merged
weltenwort merged 1 commit into
weltenwort merged 1 commit into
Conversation
Contributor
|
Pinging @elastic/infrastructure-ui |
Contributor
💚 Build Succeeded |
jasonrhodes
approved these changes
May 22, 2019
jasonrhodes
left a comment
Member
There was a problem hiding this comment.
Oh wow, looks like this was broken for more than just Safari:
Source: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow#Browser_compatibility
Fix LGTM
Member
Author
|
Interesting, I could have sworn I saw this working on IE11 🤷♀️ |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
May 22, 2019
…c#36820) This prevents the autocompletion suggestions from overflowing the dropdown in the Infra UI and Logs UI query bar.
weltenwort
added a commit
that referenced
this pull request
May 23, 2019
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
May 23, 2019
…c#36820) This prevents the autocompletion suggestions from overflowing the dropdown in the Infra UI and Logs UI query bar.
weltenwort
added a commit
that referenced
this pull request
May 23, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…c#36820) This prevents the autocompletion suggestions from overflowing the dropdown in the Infra UI and Logs UI query bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prevents the autocompletion suggestions from overflowing the dropdown in the Infra UI and Logs UI query bar.
fixes #36789
Previews
Before
After
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately