Repository navigation
fix: restore removed class used for modal focus - #36924
Merged
Merged
Conversation
w33ble
added a commit
that referenced
this pull request
May 22, 2019
Contributor
Author
|
7.x 5e6df14 |
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
Contributor
|
This missed the backport to 7.2 by a day. Spoke to @cqliu1 and the fix is in master and 7.x. |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When opening the "Add Element" modal, it used to focus the search input so users could immediately start typing and filter down the elements. This works via class selection, but the class that was being used was removed along the way.
This PR just adds the class back to restore the default input focus. The breaking change came, I think, from #34140.
Currently, no focus
Focus, restored in this PR