Skip to content

[Monitoring] Fix 500 error from /api/stats - #36986

Merged
chrisronline merged 3 commits into
elastic:masterfrom
chrisronline:monitoring/stats_endpoint_500
May 24, 2019
Merged

[Monitoring] Fix 500 error from /api/stats#36986
chrisronline merged 3 commits into
elastic:masterfrom
chrisronline:monitoring/stats_endpoint_500

Conversation

@chrisronline

@chrisronline chrisronline commented May 23, 2019

Copy link
Copy Markdown
Contributor

Fixes #36943

Introduced by #35691

Added a test too. Fairly self-explanatory. Need to backport everywhere #35691 went

@chrisronline
chrisronline requested a review from ycombinator May 23, 2019 13:57
@chrisronline chrisronline self-assigned this May 23, 2019
@elasticmachine

elasticmachine commented May 23, 2019

Copy link
Copy Markdown
Contributor

Pinging @elastic/stack-monitoring

ycombinator
ycombinator reviewed May 23, 2019
View reviewed changes
Comment thread src/legacy/server/status/routes/api/register_stats.js Outdated
ycombinator
ycombinator approved these changes May 23, 2019
View reviewed changes

@ycombinator ycombinator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ycombinator
ycombinator reviewed May 23, 2019
View reviewed changes
Comment thread test/api_integration/apis/stats/stats.js Outdated
@elasticmachine

elasticmachine commented May 23, 2019

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

elasticmachine commented May 23, 2019

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@chrisronline
chrisronline merged commit eb2ede6 into elastic:master May 24, 2019
@chrisronline
chrisronline deleted the monitoring/stats_endpoint_500 branch May 24, 2019 13:11
chrisronline added a commit to chrisronline/kibana that referenced this pull request May 24, 2019
@chrisronline
[Monitoring] Fix 500 error from /api/stats (elastic#36986)
b2a9df8 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
@chrisronline chrisronline mentioned this pull request May 24, 2019
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request May 24, 2019
@chrisronline
[Monitoring] Fix 500 error from /api/stats (elastic#36986)
2c87925 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
This was referenced May 24, 2019
Merged
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request May 24, 2019
@chrisronline
[Monitoring] Fix 500 error from /api/stats (elastic#36986)
28ad225 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
chrisronline added a commit to chrisronline/kibana that referenced this pull request May 24, 2019
@chrisronline
[Monitoring] Fix 500 error from /api/stats (elastic#36986)
cc580a8 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
This was referenced May 24, 2019
Closed
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request May 24, 2019
@chrisronline
Backport elastic#36986 to 6.8
a7bb09d
chrisronline added a commit that referenced this pull request May 24, 2019
@chrisronline
[Monitoring] Fix 500 error from /api/stats (#36986) (#37082)
cf9fdaa 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
@chrisronline

chrisronline commented May 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Backport:

7.x: cf9fdaa
7.2: b0b1c57
7.1: 8ba8b98
6.8: 866ad9b

chrisronline added a commit that referenced this pull request May 24, 2019
@chrisronline
[6.8] [Monitoring] Fix 500 error from /api/stats (#36986) (#37087)
866ad9b 
* Backport #36986 to 6.8

* Undo changes that aren't supposed to be here
chrisronline added a commit that referenced this pull request May 24, 2019
@chrisronline
[Monitoring] Fix 500 error from /api/stats (#36986) (#37083)
b0b1c57 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
chrisronline added a commit that referenced this pull request May 28, 2019
@chrisronline
[Monitoring] Fix 500 error from /api/stats (#36986) (#37085)
8ba8b98 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@chrisronline
[Monitoring] Fix 500 error from /api/stats (elastic#36986)
64eeae2 
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@chrisronline chrisronline

Labels

review Team:Monitoring Stack Monitoring team v6.8.1 v7.0.2 v7.2.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stats API fails with 500 when certain query string parameters are used

3 participants

@chrisronline @elasticmachine @ycombinator