Repository navigation
[Monitoring] Once the buffer has any events, the collector is always ready - #36995
Merged
chrisronline merged 2 commits intoMay 24, 2019
Merged
chrisronline merged 2 commits into
chrisronline merged 2 commits into
Conversation
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
|
@chrisronline The setting in the test server is one we added, right? Just trying to recall... |
Contributor
Author
Yes, that's right. Introduced by #36153 |
Contributor
💔 Build Failed |
…ready_for_stats_collector
Contributor
|
Hmmmm, yeah, I can't think of a way at the moment. Perhaps this is a test that could go into https://github.com/elastic/elastic-stack-testing (not as part of monitoring parity tests but maybe there's another place in that repo)? |
Contributor
Author
|
I opened #37009 to track the need to add tests |
Contributor
💚 Build Succeeded |
ycombinator
reviewed
May 24, 2019
| isReady: () => { | ||
| if (!bufferHadEvents) { | ||
| bufferHadEvents = buffer.hasEvents(); | ||
| } |
Contributor
There was a problem hiding this comment.
Nit: you could replace this if block with:
bufferHadEvents = bufferHadEvents || buffer.hasEvents();
ycombinator
approved these changes
May 24, 2019
ycombinator
left a comment
Contributor
There was a problem hiding this comment.
Left a nitpicky comment which you can take or ignore. LGTM.
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
that referenced
this pull request
May 24, 2019
Contributor
Author
chrisronline
added a commit
that referenced
this pull request
May 24, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 23, 2019
chrisronline
added a commit
that referenced
this pull request
Sep 23, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36991
Copied from the issue:
To test, repeatably hit the
/api/stats?extendedendpoint and ensure that once it returns a 200, it always return a 200.My test bash script:
Note: I'm not sure we can add a test for this, as this configuration circumvents the potential 500 response