Repository navigation
[Uptime] Reduce bucket size for monitor list query - #36071
Merged
justinkambic merged 3 commits intoMay 10, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/uptime |
Contributor
💚 Build Succeeded |
justinkambic
force-pushed
the
uptime_make-histogram-smaller
branch
from
May 9, 2019 12:49
c925166 to
2e9fa1b
Compare
Contributor
💚 Build Succeeded |
andrewvc
approved these changes
May 9, 2019
andrewvc
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tested locally on browser as well
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
May 10, 2019
* Reduce bucket size for monitor list query. * Stop using auto_histogram. * Update test fixtures to handle changed histogram logic.
justinkambic
added a commit
that referenced
this pull request
May 10, 2019
Contributor
Author
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Reduce bucket size for monitor list query. * Stop using auto_histogram. * Update test fixtures to handle changed histogram logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves elastic/uptime#34.
We have had reports of users encountering bucket overflow for one of our queries. We will be revisiting a number of these queries soon when we've implemented the states index. In the meantime, I propose we
reduce the number of buckets for the monitor list query. It should be within the limits that default clusters will permit.start calculating our bucket size based on the given date range, and stop relying onauto_date_histogram, because it's proven challenging to create predictable aggregation output using it.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers