Repository navigation
[Maps] Support multiple basemap styles #36074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
d64ba5d
Async TMS methods
nickpeihl 3396cc3
Fix attribution
nickpeihl ff42f60
Add human readable name to tile layers
nickpeihl 07f5013
getMinZoom and getMaxZoom are async
nickpeihl 47b8f38
Update manifestServiceUrl
nickpeihl 946b66d
Add desaturate tiles checkbox to region maps
nickpeihl ec50ce4
Deprecate desaturation
nickpeihl dfe5046
Fix ems_client tests
nickpeihl 98b3183
Human readable base layer names in tilemaps
nickpeihl 30da60a
Merge branch 'master' of https://github.com/elastic/kibana into ems-v7.2
nickpeihl 8439f1c
Fix EMS service settings test
nickpeihl 26e7fba
Enable multiple basemap styles for Vega Maps
nickpeihl d4e2585
Revert desaturation option in region maps
nickpeihl db49c88
Choose EMS basemap automagically in legacy viz
nickpeihl 21eefda
Add service_settings tests
nickpeihl 798f365
Merge branch 'master' of https://github.com/elastic/kibana into ems-v7.2
nickpeihl 62ce92d
Default to dark tile map when dark theme is et
nickpeihl 9560c7a
Vega use dark map when Kibana dark theme is set
nickpeihl 7b6dd0b
Review feedback
nickpeihl 007de2e
Get zoom levels and attribution from correct style
nickpeihl 9974aa4
Fix unreachable `return`
nickpeihl 3e9a548
Add origin to getAttributesForTMSLayer
nickpeihl c398ebe
Merge branch 'master' of https://github.com/elastic/kibana into ems-v7.2
nickpeihl 583ddb0
Mock chrome.getInjected for test
nickpeihl aa0b8a3
Use human readable name of basemap for functional test
nickpeihl 7e1a7fc
Remove TODO
nickpeihl 299b090
Merge branch 'master' of https://github.com/elastic/kibana into ems-v7.2
nickpeihl c382ee3
Wait for baseLayer logic before loading tiles for existing visualizat…
nickpeihl 7b4d09e
Revert "Wait for baseLayer logic before loading tiles for existing vi…
nickpeihl e9aff9a
Remove hard-coded EMS layer
nickpeihl e6837e2
Fix baselayer options
nickpeihl 1ccae01
Merge branch 'master' of https://github.com/elastic/kibana into ems-v7.2
nickpeihl bcee10c
Fix test
nickpeihl 607ab0a
Merge branch 'master' of https://github.com/elastic/kibana into ems-v7.2
nickpeihl c5ddbb9
Merge branch 'master' of https://github.com/elastic/kibana into ems-v7.2
nickpeihl 39dc62c
Fix test to match dummy value
nickpeihl 4678f7a
Update tests to reflect updated tile service names
nickpeihl 435d1de
Revert "Update tests to reflect updated tile service names"
nickpeihl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
src/legacy/ui/public/vis/__tests__/map/ems_mocks/sample_style_bright.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "tilejson": "2.0.0", | ||
| "name": "OSM Bright", | ||
| "attribution": "<a href=\"https://www.maptiler.com/copyright/\" target=\"_blank\">© MapTiler</a> <a href=\"https://www.openstreetmap.org/copyright\" target=\"_blank\">© OpenStreetMap contributors</a>", | ||
| "minzoom": 0, | ||
| "maxzoom": 10, | ||
| "bounds": [-180, -85.0511, 180, 85.0511], | ||
| "format": "png", | ||
| "type": "baselayer", | ||
| "tiles": ["https://raster-style.foobar/styles/osm-bright/{z}/{x}/{y}.png"], | ||
| "center": [0, 0, 2] | ||
| } |
12 changes: 12 additions & 0 deletions
12
src/legacy/ui/public/vis/__tests__/map/ems_mocks/sample_style_dark.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "tilejson": "2.0.0", | ||
| "name": "Dark Matter", | ||
| "attribution": "<a href=\"https://www.maptiler.com/copyright/\" target=\"_blank\">© MapTiler</a> <a href=\"https://www.openstreetmap.org/copyright\" target=\"_blank\">© OpenStreetMap contributors</a>", | ||
| "minzoom": 0, | ||
| "maxzoom": 22, | ||
| "bounds": [-180, -85.0511, 180, 85.0511], | ||
| "format": "png", | ||
| "type": "baselayer", | ||
| "tiles": ["https://raster-style.foobar/styles/dark-matter/{z}/{x}/{y}.png"], | ||
| "center": [0, 0, 2] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.