Repository navigation
[Infra UI] Brushing for Metrics Explorer Charts - #36235
Merged
simianhacker merged 78 commits intoMay 17, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/infrastructure-ui |
Contributor
💚 Build Succeeded |
…rer-chart-brushing
Contributor
💚 Build Succeeded |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
May 17, 2019
* Returning live data * Adding TSVB data population * adding tests * Adding UI * Adding rough draft of metrics control * Breaking out metric component; adding useCallback to callbacks; adding intl strings * seperating out form * Break metrics form out; change to custom color picker; create custom color palette; * fixing bug with color picker * changes to color palette; fix callback issue * Fixing count label * Fix chart label to truncate * Changing by to graph per * Making the metric popover wider to ease field name truncation * critical changes to the import order * Changing metrics behavior * Hide metrics when choosing document count * Updating chart tooltip; fixing types; * Setting intial state to open metrics; Tweaking toolbar sizes * fixing linting issues * Allow users to filter by a grouping by clicking on the title * Change rate to rateMax; add rateMin and rateAvg; fix title text-align * Use relative paths to fix base path bug * fixing typescript errors; removing rateAvg and rateMin; removing extranious files; * Fixing formatting issues * Fixing i18n linting errors * Changing to elastic-charts * fixing typing errors with charts * Moving afterKey out of URL to fix bug with pagination * Adding support for multiple axises * Adding tests for useMetricsExplorerData hook * breaking up the charting code; removing multi-axis support; changing color palette to use blue and red for first two color * Adding drop down menu to charts for filtering and linking to TSVB * Adding more tests for useMetricsExplorerData hook; adding error message; adding chart options to non-groupby charts * only display groupings that have the metric fields * Refactor page level state into custom hook; add test for options handlers; * Fixing linting * removing color picker * removing useInterval * Changing group by to use the pills; Changing context menu button; adding icons to context menu. * Adding test for color palette * Adding test for createFormatterForMetric() * removing tsx extension; adding tests for createMetricLabel() * removing tsx extension; adding tests for createMetricLabel() * re-organizing helpers * Moving helpers from libs to helpers; adding test for metricToFormat * Fixing bug in tsvb link fn; adding timeRange props; adding createTSVBLink() test * fixing timeRange fixture import; fixing aria label for action button * removing some unecessary useCallbacks * Adding test for MetricsExplorerChartContextMenu component * Fixing linting issues * Optimizing test * Adding empty prompts for no metrics and no data * Removing duplicate sereis def * tcs has lost it's mind so I had to copy enzyme_helpers.tsx into our plugin * Appeasing prettier * Update x-pack/plugins/infra/public/components/metrics_exploerer/metrics.tsx Co-Authored-By: simianhacker <chris@chriscowan.us> * fixing path typo * Adding supportFiltering to dependicy; change options to be more specific * remove typo * Fixing typo * Adding logColumns to source fixture; fixing typo * Fixing path to be more sane * Adding brushing to Metrics Explorer Charts
Contributor
💔 Build Failed |
simianhacker
added a commit
that referenced
this pull request
May 19, 2019
* Returning live data * Adding TSVB data population * adding tests * Adding UI * Adding rough draft of metrics control * Breaking out metric component; adding useCallback to callbacks; adding intl strings * seperating out form * Break metrics form out; change to custom color picker; create custom color palette; * fixing bug with color picker * changes to color palette; fix callback issue * Fixing count label * Fix chart label to truncate * Changing by to graph per * Making the metric popover wider to ease field name truncation * critical changes to the import order * Changing metrics behavior * Hide metrics when choosing document count * Updating chart tooltip; fixing types; * Setting intial state to open metrics; Tweaking toolbar sizes * fixing linting issues * Allow users to filter by a grouping by clicking on the title * Change rate to rateMax; add rateMin and rateAvg; fix title text-align * Use relative paths to fix base path bug * fixing typescript errors; removing rateAvg and rateMin; removing extranious files; * Fixing formatting issues * Fixing i18n linting errors * Changing to elastic-charts * fixing typing errors with charts * Moving afterKey out of URL to fix bug with pagination * Adding support for multiple axises * Adding tests for useMetricsExplorerData hook * breaking up the charting code; removing multi-axis support; changing color palette to use blue and red for first two color * Adding drop down menu to charts for filtering and linking to TSVB * Adding more tests for useMetricsExplorerData hook; adding error message; adding chart options to non-groupby charts * only display groupings that have the metric fields * Refactor page level state into custom hook; add test for options handlers; * Fixing linting * removing color picker * removing useInterval * Changing group by to use the pills; Changing context menu button; adding icons to context menu. * Adding test for color palette * Adding test for createFormatterForMetric() * removing tsx extension; adding tests for createMetricLabel() * removing tsx extension; adding tests for createMetricLabel() * re-organizing helpers * Moving helpers from libs to helpers; adding test for metricToFormat * Fixing bug in tsvb link fn; adding timeRange props; adding createTSVBLink() test * fixing timeRange fixture import; fixing aria label for action button * removing some unecessary useCallbacks * Adding test for MetricsExplorerChartContextMenu component * Fixing linting issues * Optimizing test * Adding empty prompts for no metrics and no data * Removing duplicate sereis def * tcs has lost it's mind so I had to copy enzyme_helpers.tsx into our plugin * Appeasing prettier * Update x-pack/plugins/infra/public/components/metrics_exploerer/metrics.tsx Co-Authored-By: simianhacker <chris@chriscowan.us> * fixing path typo * Adding supportFiltering to dependicy; change options to be more specific * remove typo * Fixing typo * Adding logColumns to source fixture; fixing typo * Fixing path to be more sane * Adding brushing to Metrics Explorer Charts
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Returning live data * Adding TSVB data population * adding tests * Adding UI * Adding rough draft of metrics control * Breaking out metric component; adding useCallback to callbacks; adding intl strings * seperating out form * Break metrics form out; change to custom color picker; create custom color palette; * fixing bug with color picker * changes to color palette; fix callback issue * Fixing count label * Fix chart label to truncate * Changing by to graph per * Making the metric popover wider to ease field name truncation * critical changes to the import order * Changing metrics behavior * Hide metrics when choosing document count * Updating chart tooltip; fixing types; * Setting intial state to open metrics; Tweaking toolbar sizes * fixing linting issues * Allow users to filter by a grouping by clicking on the title * Change rate to rateMax; add rateMin and rateAvg; fix title text-align * Use relative paths to fix base path bug * fixing typescript errors; removing rateAvg and rateMin; removing extranious files; * Fixing formatting issues * Fixing i18n linting errors * Changing to elastic-charts * fixing typing errors with charts * Moving afterKey out of URL to fix bug with pagination * Adding support for multiple axises * Adding tests for useMetricsExplorerData hook * breaking up the charting code; removing multi-axis support; changing color palette to use blue and red for first two color * Adding drop down menu to charts for filtering and linking to TSVB * Adding more tests for useMetricsExplorerData hook; adding error message; adding chart options to non-groupby charts * only display groupings that have the metric fields * Refactor page level state into custom hook; add test for options handlers; * Fixing linting * removing color picker * removing useInterval * Changing group by to use the pills; Changing context menu button; adding icons to context menu. * Adding test for color palette * Adding test for createFormatterForMetric() * removing tsx extension; adding tests for createMetricLabel() * removing tsx extension; adding tests for createMetricLabel() * re-organizing helpers * Moving helpers from libs to helpers; adding test for metricToFormat * Fixing bug in tsvb link fn; adding timeRange props; adding createTSVBLink() test * fixing timeRange fixture import; fixing aria label for action button * removing some unecessary useCallbacks * Adding test for MetricsExplorerChartContextMenu component * Fixing linting issues * Optimizing test * Adding empty prompts for no metrics and no data * Removing duplicate sereis def * tcs has lost it's mind so I had to copy enzyme_helpers.tsx into our plugin * Appeasing prettier * Update x-pack/plugins/infra/public/components/metrics_exploerer/metrics.tsx Co-Authored-By: simianhacker <chris@chriscowan.us> * fixing path typo * Adding supportFiltering to dependicy; change options to be more specific * remove typo * Fixing typo * Adding logColumns to source fixture; fixing typo * Fixing path to be more sane * Adding brushing to Metrics Explorer Charts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is based on #35846. Before you review this please ensure that has been merged. This PR closes #36034 by adding a brush handler to the Metrics Explorer Charts.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately