Repository navigation
Added promise with cancel with typescript support - #36293
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/stack-monitoring |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
igoristic
marked this pull request as ready for review
May 22, 2019 17:36
Contributor
Author
|
retest |
chrisronline
approved these changes
May 22, 2019
chrisronline
left a comment
Contributor
There was a problem hiding this comment.
This works great. Code is clean and well written. Great job! LGTM!
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
May 23, 2019
* Added promise with cancel * Fixed imports * Fixed an async unit test
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
May 23, 2019
* Added promise with cancel * Fixed imports * Fixed an async unit test
Contributor
Author
|
Backport: |
Contributor
|
@igoristic I see that this PR was merged ~6 hours ago. At that time, version 7.1.0 of Kibana had already been released. So we should remove the 7.1.0 label from this PR. Otherwise it will be confusing to users who try to figure out which releases this fix went into. |
igoristic
added a commit
that referenced
this pull request
May 23, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Added promise with cancel * Fixed imports * Fixed an async unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #28863
Created a simple cancelable promise, and added basic support for typescript.
Typescript will only be compiled in
x-pack/monitoring/common/*for now, and we'll add additional directories as we add more features / static class etcChecklist