Skip to content

Typecasting the attr boolean to the correct type - #37031

Merged
igoristic merged 1 commit into
elastic:masterfrom
igoristic:33838
May 24, 2019
Merged

igoristic merged 1 commit into
elastic:masterfrom
igoristic:33838

Conversation

@igoristic

Copy link
Copy Markdown
Contributor

Summary

Resolves #33838

Passing values as attributes to directives typecasts it to a string (when parsing with {{}}).

@igoristic igoristic added bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team v8.0.0 v7.2.0 labels May 23, 2019
@igoristic
igoristic requested a review from chrisronline May 23, 2019 21:08
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/stack-monitoring

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@chrisronline chrisronline left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it down and can see the CCR tab while on the ML jobs page! LGTM!

@igoristic
igoristic merged commit ec1dc71 into elastic:master May 24, 2019
@igoristic
igoristic deleted the 33838 branch May 24, 2019 15:28
igoristic added a commit to igoristic/kibana that referenced this pull request May 24, 2019
@igoristic

Copy link
Copy Markdown
Contributor Author

Backport:
7.x: f0c3aa0

@chrisronline

Copy link
Copy Markdown
Contributor

@igoristic I don't see this PR in the 7.2 branch. Do you mind backporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team v7.2.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CCR tab is missing in Jobs monitoring page

3 participants