Skip to content

[ML] Fix for constant polling of deleting job tasks - #38013

Merged
jgowdyelastic merged 2 commits into
elastic:masterfrom
jgowdyelastic:fix-deleting-job-tasks-poll
Jun 5, 2019
Merged

jgowdyelastic merged 2 commits into
elastic:masterfrom
jgowdyelastic:fix-deleting-job-tasks-poll

Conversation

@jgowdyelastic

@jgowdyelastic jgowdyelastic commented Jun 4, 2019 •

Copy link
Copy Markdown
Member

If a deleting job task was stopped due to the es node being shut down, the job being deleted can get into a situation where it's state is deleting but there is no current task actually deleting it.
In this situation the jobs list and deleting task polls start to loop uncontrollably.

This PR removes the chance of a polling infinite loop happening in this situation.

@jgowdyelastic
jgowdyelastic requested a review from a team as a code owner June 4, 2019 16:33
@jgowdyelastic jgowdyelastic self-assigned this Jun 4, 2019
@jgowdyelastic jgowdyelastic added :ml bug Fixes for quality problems that affect the customer experience v6.8.1 v7.2.0 v7.3.0 v8.0.0 labels Jun 4, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic

Copy link
Copy Markdown
Member Author

retest

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@alvarezmelissa87 alvarezmelissa87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@jgowdyelastic
jgowdyelastic merged commit 8bdecb0 into elastic:master Jun 5, 2019
@jgowdyelastic
jgowdyelastic deleted the fix-deleting-job-tasks-poll branch June 5, 2019 13:05
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jun 5, 2019
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jun 5, 2019
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jun 5, 2019
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
jgowdyelastic added a commit that referenced this pull request Jun 5, 2019
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
jgowdyelastic added a commit that referenced this pull request Jun 5, 2019
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
jgowdyelastic added a commit that referenced this pull request Jun 5, 2019
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* [ML] Fix for constant polling of deleting job tasks

* fixing comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience :ml review v6.8.1 v7.2.0 v7.3.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants