Repository navigation
[Infra UI] Fixes Uptime link to display for pod and containers - #38125
Merged
simianhacker merged 6 commits intoJun 7, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/infra-logs-ui |
Contributor
💔 Build Failed |
jasonrhodes
reviewed
Jun 5, 2019
simianhacker
marked this pull request as ready for review
June 5, 2019 18:21
jasonrhodes
reviewed
Jun 5, 2019
| ...(apmTracesUrl ? [apmTracesUrl] : []), | ||
| ...(uptimeUrl ? [uptimeUrl] : []), | ||
| ...(showLogsLink && nodeLogsMenuItem ? [nodeLogsMenuItem] : []), | ||
| nodeDetailMenuItem, |
Member
There was a problem hiding this comment.
are these top two here using the same logic as before? I thought all 4 would now be ...(showX ? [X] : [])
Member
Author
There was a problem hiding this comment.
sorry... the && nodeLogsMenuItem is not suppose to be there. The nodeDetailMenuItem is always available. The original had a check for node.id which is always true so it didn't make sense to add a check for something that's never null.
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💔 Build Failed |
jasonrhodes
approved these changes
Jun 6, 2019
Contributor
💚 Build Succeeded |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jun 7, 2019
…ic#38125) * Fixes uptime link to display for pod and containers * Making code more readable * Another round of readability changes * removing extra truthy check
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jun 7, 2019
…ic#38125) * Fixes uptime link to display for pod and containers * Making code more readable * Another round of readability changes * removing extra truthy check
simianhacker
added a commit
that referenced
this pull request
Jun 7, 2019
… (#38419) * Fixes uptime link to display for pod and containers * Making code more readable * Another round of readability changes * removing extra truthy check
simianhacker
added a commit
that referenced
this pull request
Jun 7, 2019
… (#38418) * Fixes uptime link to display for pod and containers * Making code more readable * Another round of readability changes * removing extra truthy check
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…ic#38125) * Fixes uptime link to display for pod and containers * Making code more readable * Another round of readability changes * removing extra truthy check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Uptime link so it always displays for Docker and Kubernetes nodes. It was originally broken when we limited the link to only
host.ip.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility