Repository navigation
Fetch options for input control child select boxes - #38148
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
flash1293
self-requested a review
June 7, 2019 08:57
timroes
approved these changes
Jun 7, 2019
timroes
left a comment
Contributor
There was a problem hiding this comment.
Code LGTM, tested on Chrome Linux, requests are now also made for child components.
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 7, 2019
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 7, 2019
nreese
added a commit
that referenced
this pull request
Jun 7, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #38128
The actual fix is only a few changes in list_control_factory.
The rest of the changes resulted in the input control functional tests needed some refactoring.