Repository navigation
Adds capability to show percentages for data table columns - #39572
Conversation
💚 Build Succeeded |
e69c166 to
e0c99e1
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
markov00
left a comment
There was a problem hiding this comment.
Code LGTM.
I've tested locally and I think there is one more thing to watch: when using a metric different from Count, and you add the percentage column, if than you change the aggregation field to a different one (using average agg for example on bytes first and then on machine.ram or another value) the column disappear but the editor keep showing the show percentage checkbox flagged and the dropdown selected. Removing the checkbox, applying, and reapplying the checkbox the column does not appear again. It will appear again only when changing the aggregation function.
Another small note: could you please move the checkbox just before the multiselect function?
1d0aeea to
6758f6d
Compare
💔 Build Failed |
6758f6d to
56e17ae
Compare
💔 Build Failed |
💚 Build Succeeded |
|
Pinging @elastic/kibana-app |
markov00
left a comment
There was a problem hiding this comment.
There is an issue when using this percentage function together with the show total function with something different than sum.
I think we should always display the percentage based on the sum of all the column values, not based on a different computed total.
I've also left some other minor commit/discussion points
💚 Build Succeeded |
markov00
left a comment
There was a problem hiding this comment.
Changes LGTM. Tested locally.
There is just a minor issue but I think that should be addressed on a different PR on the aggconfig side:
In this case the field still a numeric field but the format is different (string). @timroes shall we fix on some other level?
|
@markov00 I would tackle that in a separate PR. |
💚 Build Succeeded |
…9572) * Bring table vis params styles inline with others * Add percentage column option to table vis * fixup! Add percentage column option to table vis * fixup! Add percentage column option to table vis
|
@myasonik thank you so much for this! It works perfectly in 7.4.0 that got released today. The next step forward would be to add ability to show percentile for multiple columns. Don't want to sound ungrateful though, very nice implementation that's been sorely lacking from Kibana. |
…9572) * Bring table vis params styles inline with others * Add percentage column option to table vis * fixup! Add percentage column option to table vis * fixup! Add percentage column option to table vis
Summary
Add a configurable percentage column option to the table vis, closes #19489
Checklist
For maintainers