Repository navigation
[maps] Make default EMS tile layer auto select light or dark tiles based on isDark mode advanced setting - #40892
Merged
Merged
Conversation
…sed on isDark mode advanced setting
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
💚 Build Succeeded |
thomasneirynck
left a comment
Contributor
There was a problem hiding this comment.
100% agreed that this is better default behavior.
I would not overload the id-property. See comments for details. Minor suggestions wrt UX
nickpeihl
approved these changes
Jul 12, 2019
nickpeihl
left a comment
Contributor
There was a problem hiding this comment.
this is much better behavior. lgtm!
tested in firefox
Contributor
Author
|
I changed the descriptor to have the shape
|
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 12, 2019
…sed on isDark mode advanced setting (elastic#40892) * [maps] Make default EMS tile layer auto select light or dark tiles based on isDark mode advanced setting * clean up * remove console statements * review feedback
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…sed on isDark mode advanced setting (elastic#40892) * [maps] Make default EMS tile layer auto select light or dark tiles based on isDark mode advanced setting * clean up * remove console statements * review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its pretty annoying when you switch Kibana from light/dark mode and your EMS tiles do not switch theme as well.
This PR adds an
autoEMS tile service id which selects the EMS tile layer based on theme:darkMode advanced setting