Repository navigation
[Maps] Provide indication in LayerTOC when results are incomplete - #41271
Merged
thomasneirynck merged 11 commits intoJul 19, 2019
Merged
thomasneirynck merged 11 commits into
thomasneirynck merged 11 commits into
Conversation
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
nreese
approved these changes
Jul 17, 2019
nreese
left a comment
Contributor
There was a problem hiding this comment.
lgtm
code review, tested in chrome
| return `${entitiesFoundMsg} ${trimmedMsg}`; | ||
| return { | ||
| tooltipContent: `${entitiesFoundMsg} ${trimmedMsg}`, | ||
| areResultsTrimmed: false |
Contributor
There was a problem hiding this comment.
Should this be set to true? Top hits results are trimmed and show only most recent hits.
Contributor
Author
There was a problem hiding this comment.
imho they are not trimmed. It's the intention of the user to limit results in this case.
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
cchaos
suggested changes
Jul 18, 2019
cchaos
left a comment
Contributor
There was a problem hiding this comment.
The one problem I’m noticing is that if the label is long enough to get truncated, you won’t see that indicator. If you’re ok with that, then I just have the few suggestions. Otherwise, it would take more effort to ensure that it’s always visible.
Contributor
💔 Build Failed |
…omplete_indicator
Contributor
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 19, 2019
thomasneirynck
added a commit
that referenced
this pull request
Jul 19, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40805
After discussion with @cchaos, use info-button until we have dedicated icon.
Draft 3: use dagger https://en.wikipedia.org/wiki/Dagger_(typography) instead.EDIT: Changed this to using an asterix behind the layer name and greying out the layernameDraft 2:Draft 1:Add a small info button to show this is the case. The tooltip-contents remain the same.The info button is not there when all results are shown.