Skip to content

[Console] Added doc_values to list of completion items for mapping - #42581

Merged
jloleysens merged 3 commits into
elastic:masterfrom
jloleysens:fix/doc_values_autocomplete
Aug 5, 2019
Merged

jloleysens merged 3 commits into
elastic:masterfrom
jloleysens:fix/doc_values_autocomplete

Conversation

@jloleysens

@jloleysens jloleysens commented Aug 5, 2019 •

Copy link
Copy Markdown
Contributor

Summary

Addresses this issue.

Screenshots

Before completion Screenshot 2019-08-05 at 11 00 44
After completion Screenshot 2019-08-05 at 11 00 58

Release Note

Added missing autocompletion items doc_values and eager_global_ordinals. Used when creating an index with mappings.

@jloleysens jloleysens added Feature:Console Dev Tools Console Feature enhancement New value added to drive a business result v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.4.0 labels Aug 5, 2019
@jloleysens
jloleysens requested review from cjcenizal and loixlab August 5, 2019 09:08
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/es-ui

@jloleysens jloleysens added the release_note:skip Skip the PR/issue when compiling release notes label Aug 5, 2019
…s_autocomplete

* 'master' of github.com:elastic/kibana: (189 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...

@loixlab loixlab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not test locally

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jloleysens

Copy link
Copy Markdown
Contributor Author

Also adding eager_global_ordinals tested against ES 7.4

Not entirely sure about enabled - seems like it does the same thing as index.

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@loixlab

loixlab commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

Cool, thanks 👍
I had to look also for the difference between index and enabled and found this discuss explaining it: https://discuss.elastic.co/t/whats-the-difference-between-enabled-index-and-store/10717/4

@jloleysens

Copy link
Copy Markdown
Contributor Author

@sebelga Great, thanks for that!

@jloleysens
jloleysens merged commit 735a56b into elastic:master Aug 5, 2019
@jloleysens
jloleysens deleted the fix/doc_values_autocomplete branch August 5, 2019 16:09
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
…lastic#42581)

* Added doc_values to list of completion items for mapping

* Added one other autocompletion.
jloleysens added a commit that referenced this pull request Aug 6, 2019
…42581) (#42618)

* Added doc_values to list of completion items for mapping

* Added one other autocompletion.
@jloleysens jloleysens added release_note:fix bug Fixes for quality problems that affect the customer experience and removed release_note:skip Skip the PR/issue when compiling release notes enhancement New value added to drive a business result labels Aug 8, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
…lastic#42581)

* Added doc_values to list of completion items for mapping

* Added one other autocompletion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.4.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants