[ML] Data frames: Analytics jobs list. by walterra · Pull Request #42598 · elastic/kibana

walterra · 2019-08-05T12:36:32Z

Summary

Part of #42516.

Introduces the data frame analytics jobs list.

Features

“Analytics” main menu item links to analytics job list
User can start/stop/delete job
User can see job stats/config in expanded row
Running analytics jobs requires the same privileges as anomaly detection; ml_user and ml_admin. Feature control is also shared with anomaly_detection.

Notes

The code is mostly a copy of the data frames transform list. Because both features are beta/experimental and it has not been definitely decided where this code will end up, transforms/analytics are for now not sharing any code.
Some features which are not yet available for analytics but are already part of transforms (e.g. audit messages, batch/continuous, job description field) were copied over and commented out.
Note the "Create" button is disabled, analytics job creation will be added in another PR. At the moment the list allows you to view jobs created via API.
Unlike transforms, the analytics API doesn't have an endpoint for previewing results, so there is no preview tab in the expanded rows.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-08-05T13:41:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-07T07:48:59Z

Pinging @elastic/ml-ui

elasticmachine · 2019-08-07T08:38:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-07T10:04:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

peteharverson · 2019-08-07T11:54:46Z

+            <p>
+              {i18n.translate('xpack.ml.dataframe.analyticsList.startModalBody', {
+                defaultMessage:
+                  'A data frame analytics job will increase search and indexing load in your cluster. Please stop the analytics job if excessive load is experienced. Are you sure you want to start this analytics job?',


Is this warning on starting an analytics job needed? We don't show one when starting an anomaly detection job for example.

The behaviour is the same as with transforms. I will revisit in a follow up after some further discussions, no definitive decision yet. Updated #42516 accordingly.

peteharverson

Tested and LGTM.

alvarezmelissa87 · 2019-08-07T16:32:05Z

+  );
+}
+
+function stringMatch(str: string | undefined, substr: string) {


Looks like this function has been created and used in a couple of other places already - transform_list.tsx and jobs_list/components/utils.js - might be worth moving to a common place.

Added a note to the project to do this in a follow up (once we have a decision where transforms/analytics code will live eventually), I intentionally didn't do any code deduplication in this PR.

alvarezmelissa87 · 2019-08-07T16:46:57Z

+
+// This component extends EuiInMemoryTable with some
+// fixes and TS specs until the changes become available upstream.
+


Will these additions be a problem once they do become available in the EUI component itself?

If time permits I'll do a EUI PR with these updates then updating this can go hand in hand.

alvarezmelissa87

Left a couple of small comments but overall LGTM ⚡️

jgowdyelastic

LGTM

jgowdyelastic · 2019-08-08T08:27:36Z

+  REFRESH_ANALYTICS_LIST_STATE.IDLE
+);
+
+export const useRefreshAnalyticsList = (


this is a nicely structured hook. i wonder if it could be used in a more general way for managing things that load.
also, could isLoading be moved to be something returned from the hook, like refresh is? i guess you'd then need something watching isLoading on the other end.

thanks! Yes I think isLoading could be moved inside the custom hook, don't remember exactly why I did it this way, maybe I had issues with updates. Just checked because someone mentioned it a while ago, APM has a generic version useFetcher() similar to this, we could have a look if we wanted to reuse it https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/public/hooks/useFetcher.tsx

jgowdyelastic · 2019-08-08T08:29:45Z

+  item: DataFrameAnalyticsListRow;
+}
+
+export const DeleteAction: SFC<DeleteActionProps> = ({ item }) => {


we probably should be using FC for all new code

Changed for all analytics code in aec4524.

elasticmachine · 2019-08-08T09:57:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-08T11:10:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-08T12:25:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-08T13:33:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

Introduces the data frame analytics jobs list.

walterra self-assigned this Aug 5, 2019

walterra added 7 commits August 6, 2019 14:08

[ML] Data frame analytics jobs list.

fc5bec2

[ML] Fixes start action and progress.

397fad2

[ML] Fix stop action.

372ed6d

[ML] Fix privileges and permissions.

b228cd3

[ML] Fix SCSS.

61149d5

[ML] Fix translation ids.

51b80b6

[ML] Fix expanded row.

bd7030d

walterra force-pushed the ml-dfa-jobs branch from 7ddea4b to bd7030d Compare August 7, 2019 07:38

walterra added :ml release_note:enhancement v7.4.0 v8.0.0 labels Aug 7, 2019

walterra requested review from alvarezmelissa87, jgowdyelastic and peteharverson August 7, 2019 07:49

walterra marked this pull request as ready for review August 7, 2019 07:49

walterra requested review from a team as code owners August 7, 2019 07:49

[ML] Fixes privileges, typescript, tests.

45013f2

peteharverson reviewed Aug 7, 2019

View reviewed changes

peteharverson approved these changes Aug 7, 2019

View reviewed changes

alvarezmelissa87 reviewed Aug 7, 2019

View reviewed changes

alvarezmelissa87 approved these changes Aug 7, 2019

View reviewed changes

walterra added the Feature:Data Frame Analytics ML data frame analytics features label Aug 8, 2019

walterra mentioned this pull request Aug 8, 2019

[ML] Data Frame Analytics: Job Management Page #42516

Closed

8 tasks done

walterra added 2 commits August 8, 2019 09:55

[ML] Hide non-supported description column from analytics job list.

56b0340

[ML] Fix IE11 flex issue.

a2c5a51

jgowdyelastic approved these changes Aug 8, 2019

View reviewed changes

[ML] Use FC instead of SFC.

aec4524

[ML] Update snapshot.

d710064

Merge branch 'master' of github.com:elastic/kibana into ml-dfa-jobs

34e5a61

Merge branch 'master' into ml-dfa-jobs

dd66112

walterra merged commit 81d7d6c into elastic:master Aug 8, 2019

walterra deleted the ml-dfa-jobs branch August 8, 2019 13:35

walterra mentioned this pull request Aug 8, 2019

[7.x] [ML] Data frames: Analytics jobs list. (#42598) #42936

Merged

walterra added a commit to walterra/kibana that referenced this pull request Aug 8, 2019

[ML] Data frames: Analytics jobs list. (elastic#42598)

a8ab590

Introduces the data frame analytics jobs list.

walterra added a commit that referenced this pull request Aug 8, 2019

[ML] Data frames: Analytics jobs list. (#42598) (#42936)

cc53b0f

Introduces the data frame analytics jobs list.

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026

[ML] Data frames: Analytics jobs list. (elastic#42598)

150f9c5

Introduces the data frame analytics jobs list.


		// This component extends EuiInMemoryTable with some
		// fixes and TS specs until the changes become available upstream.

Conversation

walterra commented Aug 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Features

Notes

Checklist

For maintainers

Uh oh!

elasticmachine commented Aug 5, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Aug 7, 2019

Uh oh!

elasticmachine commented Aug 7, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Aug 7, 2019

💚 Build Succeeded

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walterra Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walterra Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 8, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Aug 8, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Aug 8, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Aug 8, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

walterra commented Aug 5, 2019 •

edited

Loading

walterra Aug 8, 2019 •

edited

Loading

walterra Aug 8, 2019 •

edited

Loading