Repository navigation
Chore/bump chromium webgl+kerberos - #42751
joelgriffith merged 32 commits into
Conversation
💔 Build Failed |
…um-webgl-kerberos
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
tsullivan
left a comment
There was a problem hiding this comment.
Left a suggestion to do without the new puppeteer.ts file.
The maps app changes should be approved by someone in the Maps team.
| import { map, share, mergeMap, filter, partition, ignoreElements, tap } from 'rxjs/operators'; | ||
| import { InnerSubscriber } from 'rxjs/internal/InnerSubscriber'; | ||
|
|
||
| import { launch, Browser, Page } from '../puppeteer'; |
There was a problem hiding this comment.
We can also do
import { Browser, Page, LaunchOptions } from 'puppeteer';
And when we call launch we can do:
browser = await launch({
pipe: !this.browserConfig.inspect,
userDataDir,
executablePath: this.binaryPath,
ignoreHTTPSErrors: true,
args: chromiumArgs,
env: {
TZ: browserTimezone,
},
} as LaunchOptions);
That will ensure that we are doing a good job at building the object literal that gets passed. We wouldn't need the puppeteer file, but on the other hand, the launch method would not be typed quite as well as you have it.
…um-webgl-kerberos
💔 Build Failed |
|
Looks like the linux build didn't zip properly, going to fix that and re-upload the binary to S3 |
💔 Build Failed |
|
Does |
|
No, I'll remove that attribute @nreese, good catch EDIT: They are still required, sadly. |
| archive_file('Helpers/chrome_crashpad_handler') | ||
| archive_file('libswiftshader_libEGL.dylib') | ||
| archive_file('libswiftshader_libGLESv2.dylib') | ||
| archive_file(path.join('Helpers', 'chrome_crashpad_handler')) |
There was a problem hiding this comment.
this is existing, but stands out a little, and I'm wondering why we have it in the Darwin build
There was a problem hiding this comment.
I'll have to look again. The binary fails to start wo it, however I'm not sure as to why
💚 Build Succeeded |
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
| import { Browser } from 'puppeteer'; |
There was a problem hiding this comment.
this is essentially the same as the previous code, just an indirect version
tsullivan
left a comment
There was a problem hiding this comment.
I just have 1 picky point about how role of the new puppeteer file. I think it could be focused on exporting a typed launch function
💚 Build Succeeded |
tsullivan
left a comment
There was a problem hiding this comment.
LGTM! Reviewed the non-Maps part of the code changes.
💚 Build Succeeded |
* Chore/bump chromium webgl+kerberos (#42751) * WIP: Adding libs for webgl * WIP Adding swiftshader libs to chromium * WIP: Adding missing binaries for webgl in chromium * Use pipes for communication with chrome to avoid networking snafus * Bumps puppeteer in prep for new chromium build + types and better @types package * Remove ignore * Removing of final @ts-ignore now that we have types * README updates * Fixing binding issues * Fixing maps integration wrt reporting + conditional pipes for puppeteer * Adding new deps to the windows build * New s3 builds * Checksums for updated linux build * Moving types out of puppeteer file and into core puppeteer module * launch => puppeteerLaunch * Maps comment about render loading in reporting * Clarify how reporting uses hooks and events for viz * Type fix from merge conflict
|
🍾 🍾 🍾 🍾 |
* WIP: Adding libs for webgl * WIP Adding swiftshader libs to chromium * WIP: Adding missing binaries for webgl in chromium * Use pipes for communication with chrome to avoid networking snafus * Bumps puppeteer in prep for new chromium build + types and better @types package * Remove ignore * Removing of final @ts-ignore now that we have types * README updates * Fixing binding issues * Fixing maps integration wrt reporting + conditional pipes for puppeteer * Adding new deps to the windows build * New s3 builds * Checksums for updated linux build * Moving types out of puppeteer file and into core puppeteer module * launch => puppeteerLaunch * Maps comment about render loading in reporting * Clarify how reporting uses hooks and events for viz
Once chromium is built and SHA's generated I'll push them to our S3 bucket, but for now this includes updates to our typedefs (yaaa removing
@ts-ignore), and uses a better@typespackage. I had to write a small wrapper around puppeteer to get the right module "binded" to the right types.TODO: