Repository navigation
[Monitoring] Ensure we pass down all the parameters for fetching logs - #43869
Merged
chrisronline merged 8 commits intoAug 29, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/stack-monitoring |
…x_missing_log_reason
Contributor
💔 Build Failed |
Contributor
|
@chrisronline Everything looks good! Was thinking maybe we should also assign default values here: In an off case that none of the conditions were met. WDYT? |
Contributor
Author
|
@igoristic Sure, sounds good! I pushed up that change |
Contributor
💚 Build Succeeded |
igoristic
approved these changes
Aug 23, 2019
Contributor
|
LGTM! Nice work 🥇 |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
…x_missing_log_reason
Contributor
💚 Build Succeeded |
cachedout
reviewed
Aug 28, 2019
cachedout
left a comment
Contributor
There was a problem hiding this comment.
This looks good and seems very sensible! I added some minor comments and I'll wait for a reply on those for now but if there is a rush on this, I have no objection at all to approving it as it sits and merging it. LMK.
cachedout
approved these changes
Aug 28, 2019
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
Author
|
Oops, didn't see the email about CI issues. I'll wait until CI is ready before retesting |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
…x_missing_log_reason
Contributor
💚 Build Succeeded |
This was referenced Aug 29, 2019
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Aug 29, 2019
…elastic#43869) * Ensure we pass these all the way down * Add additional test * Fix tests * PR feedback * Update copy and test wording
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Aug 29, 2019
…elastic#43869) * Ensure we pass these all the way down * Add additional test * Fix tests * PR feedback * Update copy and test wording
Contributor
Author
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…elastic#43869) * Ensure we pass these all the way down * Add additional test * Fix tests * PR feedback * Update copy and test wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #43805
Unfortunate small issue of improper data marshaling. I updated the code to make this better and added a test.
Testing steps (copied from issue):
Steps to reproduce: