Repository navigation
Prevent space identifier url example from overflowing panel - #44871
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-security |
Contributor
|
ACK: reviewing now. Btw, looks like we need to update Jest snapshot @legrego |
azasypkin
approved these changes
Sep 5, 2019
azasypkin
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tested locally and everything looks good, thanks! As we discussed over slack we may need to file EUI issue related to the way EUI inputs ^handles^ with very long non-ASCII strings.
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
This was referenced Sep 5, 2019
legrego
added a commit
that referenced
this pull request
Sep 5, 2019
* ensure example url wraps properly when the space identifier is long * restrict space identifier length to 500 characters * Revert "restrict space identifier length to 500 characters" This reverts commit a34f324. * update snapshot
legrego
added a commit
that referenced
this pull request
Sep 5, 2019
* ensure example url wraps properly when the space identifier is long * restrict space identifier length to 500 characters * Revert "restrict space identifier length to 500 characters" This reverts commit a34f324. * update snapshot
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44849