Skip to content

[ML] Fixes messages in data frame action request notifications - #44872

Merged
peteharverson merged 1 commit into
elastic:masterfrom
peteharverson:ml-data-frame-action-messages
Sep 5, 2019
Merged

peteharverson merged 1 commit into
elastic:masterfrom
peteharverson:ml-data-frame-action-messages

Conversation

@peteharverson

@peteharverson peteharverson commented Sep 5, 2019 •

Copy link
Copy Markdown
Contributor

Summary

Fixes the text used in the toast notifications that are displayed from requests to create, start or stop data frame transforms and analytics jobs.

Previously we displayed messages like Data frame job {jobId} started successfully. for requests where we just get back { acknowledged: true }. This can be misleading if a job starts and fails immediately for example because of a missing source index. The messages now just indicate that the requests have been acknowledged.

image

Checklist

For maintainers

Fixes #40594

@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui

@walterra walterra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@alvarezmelissa87 alvarezmelissa87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML] Data Frames: Fix request response messages.

4 participants