Possibility to filter when testing scripted fields (#35379) by friol · Pull Request #44220 · elastic/kibana

friol · 2019-08-28T06:01:14Z

Summary

As asked in issue #35379 , I've added the possibility to perform a filter query when testing your scripted field, since not always the first 10 records are significant.

elasticmachine · 2019-08-28T06:01:25Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

spalger · 2019-08-28T18:11:57Z

retest

elasticmachine · 2019-08-28T19:39:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

spalger · 2019-08-28T21:19:34Z

retest

elasticmachine · 2019-08-30T20:37:16Z

Pinging @elastic/kibana-app

elasticmachine · 2019-08-30T22:12:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

TinaHeiligers · 2019-09-16T18:07:23Z

@friol could you please update this PR by rebasing against master?

spalger · 2019-09-16T18:35:47Z

@elasticmachine merge upstream

elasticmachine · 2019-09-16T20:56:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

friol · 2019-11-28T11:15:22Z

@spalger : Can anybody please take a look at this one? This is useful! Thanks :)

nreese · 2019-12-04T13:11:18Z

@elasticmachine merge upstream

Test script design improvement

friol · 2019-12-12T06:35:53Z

@friol thanks for making this PR! 🎉

I'm part of the Kibana Design team and I've justed created a PR with a few design changes:

We normally use a space of 16px in between form rows

We use our Elastic UI variables to address paddings and margins instead of pixels

I changed one of the class names to adhere to the BEM principle

Here's the PR: friol#5

@miukimiu done :)

elizabetdev

Thanks @friol! LGTM! 🎉

nreese · 2019-12-12T14:48:56Z

@elasticmachine merge upstream

nreese · 2019-12-13T00:39:24Z

retest

nreese · 2019-12-13T02:19:43Z

@friol CI is failing for this PR. You will need to mock out TestScript in https://github.com/elastic/kibana/blob/master/src/legacy/ui/public/field_editor/components/scripting_help/help_flyout.test.js#L28 by adding the following.

jest.mock('./test_script', () => ({
  TestScript: () => {
    return (<div>mockTestScript</div>);
  }
}));

Then run node scripts/jest help_flyout -u to update the snapshot since the mocked TestScript component does not set the default prop name.

friol · 2019-12-22T13:45:41Z

@nreese : I aligned my local repository with this branch and recompiled/restarted. Now, when I access Kibana, I get this error:

Version: 8.0.0
Build: 9007199254740991
TypeError: Cannot read property 'SearchBar' of undefined
at Object../src/legacy/ui/public/field_editor/components/scripting_help/test_script.js (http://localhost:5601/jmq/bundles/kibana.bundle.js:19120:34)
at webpack_require (http://localhost:5601/jmq/bundles/kibana.bundle.js:93:30)
at Object../src/legacy/ui/public/field_editor/components/scripting_help/help_flyout.js (http://localhost:5601/jmq/bundles/kibana.bundle.js:18811:20)
at webpack_require (http://localhost:5601/jmq/bundles/kibana.bundle.js:93:30)
at Object../src/legacy/ui/public/field_editor/components/scripting_help/index.js (http://localhost:5601/jmq/bundles/kibana.bundle.js:18883:20)
at webpack_require (http://localhost:5601/jmq/bundles/kibana.bundle.js:93:30)
at Object../src/legacy/ui/public/field_editor/field_editor.js (http://localhost:5601/jmq/bundles/kibana.bundle.js:19437:23)
at webpack_require (http://localhost:5601/jmq/bundles/kibana.bundle.js:93:30)
at Object../src/legacy/ui/public/field_editor/index.js (http://localhost:5601/jmq/bundles/kibana.bundle.js:20273:21)
at webpack_require (http://localhost:5601/jmq/bundles/kibana.bundle.js:93:30)

Why?

nreese · 2019-12-26T13:57:03Z

Looks like SearchBar was migrated to Kibana's new platform and is now imported from npStart.plugins.data.ui. Here is the PR that made the change - #52622.

friol · 2019-12-26T19:13:05Z

@nreese: ok, done, and also, updated the tests. Thanks!

nreese · 2019-12-26T21:31:16Z

@elasticmachine merge upstream

nreese · 2019-12-27T00:33:40Z

retest

kibanamachine · 2019-12-27T01:49:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ba61f32

History

💔 Build #15314 failed 72d536d
💔 Build #14090 failed 720e418

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese · 2019-12-27T03:10:09Z

@friol Thanks for the contribution. This is a great enhancement.

…lastic#44220) * Possibility to filter when testing scripted fields * Possibility to filter when testing scripted fields * Now the i18n test should pass * use SearchBar instead of EuiFieldText input * clean up * test script design improvement * Fixed SearchBar reference and updated the help_flyout tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com> Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>

nreese · 2019-12-27T03:12:26Z

7.6 #53813

friol · 2019-12-27T09:09:36Z

@friol Thanks for the contribution. This is a great enhancement.

@nreese : this was my 1st PR to Kibana and the one that made me start contributing to the project.
Thanks for your support and for making this real even after 4 months :)

…53813) * Possibility to filter when testing scripted fields * Possibility to filter when testing scripted fields * Now the i18n test should pass * use SearchBar instead of EuiFieldText input * clean up * test script design improvement * Fixed SearchBar reference and updated the help_flyout tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com> Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co> Co-authored-by: friol <dantonag@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>

* master: Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775)

…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...

…lastic#44220) * Possibility to filter when testing scripted fields * Possibility to filter when testing scripted fields * Now the i18n test should pass * use SearchBar instead of EuiFieldText input * clean up * test script design improvement * Fixed SearchBar reference and updated the help_flyout tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com> Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>

Possibility to filter when testing scripted fields

648fcc1

Possibility to filter when testing scripted fields

be05f0b

friol force-pushed the fix35379 branch from 648fcc1 to be05f0b Compare August 28, 2019 10:00

friol added 2 commits August 28, 2019 22:10

Merge branch 'fix35379' of https://github.com/friol/kibana into fix35379

91d28a6

Now the i18n test should pass

6f23055

lukeelmers added review Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Aug 30, 2019

lukeelmers added the release_note:enhancement label Aug 30, 2019

lukeelmers changed the title ~~Possibility to filter when testing scripted fields (#35379) [release_note:enhancement]~~ Possibility to filter when testing scripted fields (#35379) Aug 30, 2019

friol mentioned this pull request Sep 16, 2019

Custom space avatar images #45148

Merged

Merge branch 'master' into fix35379

3680b10

spalger added v7.5.0 v8.0.0 labels Sep 16, 2019

spalger requested a review from nreese December 4, 2019 07:37

spalger added v7.5.1 v7.6.0 and removed v7.5.0 labels Dec 4, 2019

elasticmachine and others added 2 commits December 4, 2019 05:11

Merge branch 'master' into fix35379

dc1b80e

use SearchBar instead of EuiFieldText input

8cd4cbd

Merge pull request #5 from miukimiu/friol-fix35379

033109f

Test script design improvement

elizabetdev approved these changes Dec 12, 2019

View reviewed changes

Merge branch 'master' into fix35379

72d536d

Merge remote-tracking branch 'upstream/master' into fix35379

d39379e

nreese mentioned this pull request Dec 26, 2019

scripted fields preview and validate script before saving #20746

Merged

Fixed SearchBar reference and updated the help_flyout tests

1ad99e3

Merge branch 'master' into fix35379

ba61f32

elastic deleted a comment from elasticmachine Dec 27, 2019

nreese merged commit 3ed5264 into elastic:master Dec 27, 2019

nreese mentioned this pull request Dec 27, 2019

[7.x] Possibility to filter when testing scripted fields (#35379) (#44220) #53813

Merged

nreese mentioned this pull request Mar 6, 2020

Filters or queries in scripted field results preview #35379

Closed

Conversation

friol commented Aug 28, 2019

Summary

Uh oh!

elasticmachine commented Aug 28, 2019

Uh oh!

spalger commented Aug 28, 2019

Uh oh!

elasticmachine commented Aug 28, 2019

💔 Build Failed

Uh oh!

spalger commented Aug 28, 2019

Uh oh!

elasticmachine commented Aug 30, 2019

Uh oh!

elasticmachine commented Aug 30, 2019

💚 Build Succeeded

Uh oh!

TinaHeiligers commented Sep 16, 2019

Uh oh!

spalger commented Sep 16, 2019

Uh oh!

elasticmachine commented Sep 16, 2019

💚 Build Succeeded

Uh oh!

friol commented Nov 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented Dec 4, 2019

Uh oh!

friol commented Dec 12, 2019

Uh oh!

elizabetdev left a comment

Choose a reason for hiding this comment

Uh oh!

nreese commented Dec 12, 2019

Uh oh!

nreese commented Dec 13, 2019

Uh oh!

nreese commented Dec 13, 2019

Uh oh!

friol commented Dec 22, 2019

Uh oh!

nreese commented Dec 26, 2019

Uh oh!

friol commented Dec 26, 2019

Uh oh!

nreese commented Dec 26, 2019

Uh oh!

nreese commented Dec 27, 2019

Uh oh!

kibanamachine commented Dec 27, 2019

💚 Build Succeeded

History

Uh oh!

nreese commented Dec 27, 2019

Uh oh!

nreese commented Dec 27, 2019

Uh oh!

friol commented Dec 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

friol commented Nov 28, 2019 •

edited

Loading