Repository navigation
Conversation
- Ensure we wait until jobs are actually deleted before setting up the module again - Compose deletion functions and add utility function for getting all module jobIds - Add io-ts types for cleanup responses
Contributor
|
Pinging @elastic/infra-logs-ui |
…-non-blocking-deletion-in-analysis
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
weltenwort
self-requested a review
September 23, 2019 10:43
weltenwort
approved these changes
Sep 23, 2019
weltenwort
left a comment
Member
There was a problem hiding this comment.
LGTM and seems to work well. 👍
I left just two stylistic questions below. 😇
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Sep 24, 2019
…46040) * Address non-blocking nature of job deletion ML API - Ensure we wait until jobs are actually deleted before setting up the module again - Compose deletion functions and add utility function for getting all module jobIds - Add io-ts types for cleanup responses * Reorganise functions for readability * Return the callDeleteJobs response from the overall wrapper deleteJobs function
Kerry350
added a commit
that referenced
this pull request
Sep 24, 2019
…46443) * Address non-blocking nature of job deletion ML API - Ensure we wait until jobs are actually deleted before setting up the module again - Compose deletion functions and add utility function for getting all module jobIds - Add io-ts types for cleanup responses * Reorganise functions for readability * Return the callDeleteJobs response from the overall wrapper deleteJobs function
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…46040) * Address non-blocking nature of job deletion ML API - Ensure we wait until jobs are actually deleted before setting up the module again - Compose deletion functions and add utility function for getting all module jobIds - Add io-ts types for cleanup responses * Reorganise functions for readability * Return the callDeleteJobs response from the overall wrapper deleteJobs function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #45350. When performing the cleanup operation it will now poll the
/api/ml/jobs/deleting_jobs_taskendpoint to ensure the jobs have actually been deleted, before proceeding to setup the analysis module again. It will wait 1 second between polling.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.