Repository navigation
[ML] link to calendar settings from a job config - #46141
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui |
peteharverson
requested changes
Sep 19, 2019
peteharverson
left a comment
Contributor
There was a problem hiding this comment.
One thing I noticed in testing, is that when the link opens the auto refresh control is visible on the page:
It must inherit the time range selector / auto refresh selector settings from the page from which it is opened. and the auto refresh selector is shown on the Jobs List.
I think you may need to add
timefilter.disableTimeRangeSelector();
timefilter.disableAutoRefreshSelector();
to the calendar page - either in the React component file, or the wrapping directive.
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Sep 20, 2019
* [ML] link to calendar settings from a job config * [ML] add basePath * [ML] disable auto-refresh control for calendar page * [ML] disable auto-refresh control for calendar page * [ML] disable auto-refresh control for calendar page on mount * [ML] mock timefilter
darnautov
added a commit
that referenced
this pull request
Sep 20, 2019
* [ML] link to calendar settings from a job config * [ML] add basePath * [ML] disable auto-refresh control for calendar page * [ML] disable auto-refresh control for calendar page * [ML] disable auto-refresh control for calendar page on mount * [ML] mock timefilter
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [ML] link to calendar settings from a job config * [ML] add basePath * [ML] disable auto-refresh control for calendar page * [ML] disable auto-refresh control for calendar page * [ML] disable auto-refresh control for calendar page on mount * [ML] mock timefilter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #33842. Calendar items in Job settings section are now links to the related calendar's settings page.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately