Repository navigation
[SIEM] Filter out "loading" from Panel to make it more React performant - #46258
Merged
FrankHassanabad merged 2 commits intoSep 21, 2019
Merged
FrankHassanabad merged 2 commits into
FrankHassanabad merged 2 commits into
Conversation
Contributor
|
Pinging @elastic/siem |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine update branch |
Contributor
💚 Build Succeeded |
angorayc
approved these changes
Sep 20, 2019
angorayc
left a comment
Contributor
There was a problem hiding this comment.
Thanks @FrankHassanabad, I'm happy to learn a new thing of styled component. It does make the code cleaner.
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Sep 21, 2019
…mant boolean (elastic#46258) ## Summary * This filters out the loading boolean from the EuiPanel to remove React console warnings * This makes React memo's more performant by not pushing down new objects potentially causing re-renders. * This improves the syntax usage from awkward object to a regular boolean value * This DRY (Do not Repeat Yourself) the Panel to put in one area for usage * This adds a unit test to ensure loading=true does not end up on the DOM References: styled-components/styled-components#1198 (comment) elastic#41596 (comment) https://www.styled-components.com/docs/faqs#why-am-i-getting-html-attribute-warnings https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~ ~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ ~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers ~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~ ~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
FrankHassanabad
added a commit
that referenced
this pull request
Sep 22, 2019
…mant boolean (#46258) (#46303) ## Summary * This filters out the loading boolean from the EuiPanel to remove React console warnings * This makes React memo's more performant by not pushing down new objects potentially causing re-renders. * This improves the syntax usage from awkward object to a regular boolean value * This DRY (Do not Repeat Yourself) the Panel to put in one area for usage * This adds a unit test to ensure loading=true does not end up on the DOM References: styled-components/styled-components#1198 (comment) #41596 (comment) https://www.styled-components.com/docs/faqs#why-am-i-getting-html-attribute-warnings https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~ ~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ ~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers ~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~ ~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…mant boolean (elastic#46258) ## Summary * This filters out the loading boolean from the EuiPanel to remove React console warnings * This makes React memo's more performant by not pushing down new objects potentially causing re-renders. * This improves the syntax usage from awkward object to a regular boolean value * This DRY (Do not Repeat Yourself) the Panel to put in one area for usage * This adds a unit test to ensure loading=true does not end up on the DOM References: styled-components/styled-components#1198 (comment) elastic#41596 (comment) https://www.styled-components.com/docs/faqs#why-am-i-getting-html-attribute-warnings https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~ ~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ ~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers ~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~ ~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References:
styled-components/styled-components#1198 (comment)
#41596 (comment)
https://www.styled-components.com/docs/faqs#why-am-i-getting-html-attribute-warnings
https://reactjs.org/blog/2017/09/08/dom-attributes-in-react-16.html
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately