Repository navigation
Security - allow sorting on user/roles 'reserved' column - #46283
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-security |
legrego
commented
Sep 20, 2019
| { | ||
| field: 'metadata._reserved', | ||
| name: ( | ||
| <EuiToolTip content={reservedRoleDesc}> |
Member
Author
There was a problem hiding this comment.
Removed tooltip to be consistent with the User grid page. The tooltip ended up swallowing the click event, which prevents users from initiating a sort on this column.
| }, | ||
| { | ||
| field: 'metadata._reserved', | ||
| field: 'metadata', |
Member
Author
There was a problem hiding this comment.
Changed from metadata._reserved to metadata because EUI won't allow the field to sort on this potentially undefined field
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
kobelb
approved these changes
Sep 24, 2019
Member
Author
|
@elasticmachine update branch |
Contributor
💚 Build Succeeded |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Sep 25, 2019
* allow sorting on user/roles 'reserved' column * remove unused import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* allow sorting on user/roles 'reserved' column * remove unused import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows sorting the User and Role grid pages by their "reserved" status:
Resolves #45955