Skip to content

Read warning to screen readers for duplicate saved objects - #47568

Merged
myasonik merged 1 commit into
elastic:masterfrom
myasonik:a11y-saved-searches-warning
Oct 11, 2019
Merged

myasonik merged 1 commit into
elastic:masterfrom
myasonik:a11y-saved-searches-warning

Conversation

@myasonik

@myasonik myasonik commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

Summary

Fixes #19635

Puts focus on the warning if there are duplicate objects and wires up the text box to also explain it.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios

For maintainers

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myasonik
myasonik force-pushed the a11y-saved-searches-warning branch from 7064e68 to 1339738 Compare October 11, 2019 14:01
@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@myasonik
myasonik merged commit d0c9f84 into elastic:master Oct 11, 2019
@myasonik
myasonik deleted the a11y-saved-searches-warning branch October 11, 2019 15:33
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning prompt for saving search/dashboard/visualization with the same name is not announced in screenreader

3 participants