Repository navigation
Conversation
darnautov
requested review from
alvarezmelissa87,
jgowdyelastic,
peteharverson and
walterra
October 10, 2019 13:31
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
| import { ml } from '../../services/ml_api_service'; | ||
| import { mlJobService } from '../../services/job_service'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { WIZARD_TYPE } from '../../jobs/new_job/simple/components/constants/general'; |
Contributor
There was a problem hiding this comment.
Should the values out of ml/public/jobs/new_job_new/common/job_creator/util/constants.ts be used here. @jgowdyelastic ? Or the CREATED_BY_LABEL enum in that file could be moved to a more generic constants file perhaps?
Contributor
Author
There was a problem hiding this comment.
I was thinking about CREATED_BY_LABEL, but this enum might be extended I guess because created_by might me module values as well
Contributor
💚 Build Succeeded |
| * it was created by a job wizard as the rules cannot currently be edited | ||
| * in the job wizards and so would be lost in a clone. | ||
| */ | ||
| export function processCreatedBy(customSettings) { |
Member
There was a problem hiding this comment.
maybe this function is better suited to a shared location? job_utils.js perhaps?
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 11, 2019
* [ML] delete created_by only for wizards * [ML] use CREATED_BY_LABEL enum * [ML] move processCreatedBy
darnautov
added a commit
that referenced
this pull request
Oct 11, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* [ML] delete created_by only for wizards * [ML] use CREATED_BY_LABEL enum * [ML] move processCreatedBy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #45638. Remove created_by field only in case the job has been created by wizard.
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately