Repository navigation
Timelion: Show correct value in legend for step charts - #47863
Merged
flash1293 merged 5 commits intoOct 22, 2019
Merged
Conversation
Contributor
Author
|
Jenkins, test this. |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
flash1293
marked this pull request as ready for review
October 11, 2019 14:36
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
timroes
approved these changes
Oct 22, 2019
timroes
left a comment
Contributor
There was a problem hiding this comment.
Tested on Chrome Linux. works as intended.
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 22, 2019
flash1293
added a commit
that referenced
this pull request
Oct 22, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36539
This PR changes the logic how the current data point is determined to show the current value in the legend.
If the series is shown as a stepped line or a bar chart, it will always show the value of the current bar or the data point left of the current x position. If the series is a regular line chart with interpolated values between the actual data points, it will show the value of the data point closer to the current x position - this is also how elastic-charts behaves.