Repository navigation
[APM] Garbage collection metrics charts - #47023
Conversation
💚 Build Succeeded |
af53b05 to
d280f57
Compare
💔 Build Failed |
4d3d585 to
2458fc2
Compare
💔 Build Failed |
023f3c0 to
9e7b3bc
Compare
💚 Build Succeeded
|
💚 Build Succeeded
|
9e7b3bc to
227b160
Compare
💔 Build Failed
|
227b160 to
13d14d3
Compare
💚 Build Succeeded
|
There was a problem hiding this comment.
value == null is equivalent to value === null || value === undefined
There was a problem hiding this comment.
Ah, totally missed that this was == and not ===. Not used to the former anymore 😅
There was a problem hiding this comment.
Shouldn't this be LABELS_NAME = 'labels.name'?
There was a problem hiding this comment.
Yeah, that's better. I used ${LABELS}.name because I understood labels to be fully dynamic, and I was overthinking it.
There was a problem hiding this comment.
Maybe add a comment about how the java agent sends gc.count and gc.time as monotonically increasing counters, and that we need to get the delta.
And perhaps also explain the bucket script below.
There was a problem hiding this comment.
Looking at this I'm not entirely sure what we expect value to be. If we expect it to be an integer we could do:
const y = Number.isInteger(value) ? value : null;13d14d3 to
e30de50
Compare
💚 Build Succeeded
|
|
@roncohen Right now the numbers to the legend display the average of the counter reported by the agents. I could change that to the average of the values displayed in the chart, and then round it off for the garbage collection count. Thoughts? |
|
@gieselaar to be sure:
the number in the legend would be the average displayed on the chart. For counts specifically, we'd always round to full integer, also on the popover. Thanks! 👍 |
|
@felixbarny @eyalkoren @nehaduggal please have a very close look at this to make sure the numbers and functions (max/avg etc) makes sense and that label names etc. are what you'd expect. |
|
Will this view still allow to view the metrics of different JVMs for the same service? I lost track of what the plan is in regards to the JVM table and how to navigate to the charts. It might make sense to be more explicit about the aggregation and add it to the label or the chart headline like It might be just me but maybe a short demo/sync meeting could be useful. |
e30de50 to
acbc7b7
Compare
💚 Build Succeeded |
|
@dgieselaar showed it in the APM UI weekly. If you don't mind @dgieselaar, i think it would be good to show it to the Java team + @nehaduggal to get their sign off on this. |
* [APM] Garbage collection metrics charts Closes elastic#36320. * Review feedback * Display average of delta in gc chart
* [APM] Garbage collection metrics charts Closes elastic#36320. * Review feedback * Display average of delta in gc chart
Closes #36320.