Repository navigation
[NP] Migrate field format utils to TS - #47124
Merged
gospodarsky merged 32 commits intoOct 9, 2019
Merged
gospodarsky merged 32 commits into
gospodarsky merged 32 commits into
Conversation
alexwizp
reviewed
Oct 2, 2019
Contributor
💔 Build Failed |
alexwizp
reviewed
Oct 2, 2019
alexwizp
reviewed
Oct 2, 2019
alexwizp
reviewed
Oct 2, 2019
alexwizp
reviewed
Oct 2, 2019
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
alexwizp
reviewed
Oct 4, 2019
…mats-utils-to-ts-2
added 3 commits
October 7, 2019 17:56
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
ppisljar
approved these changes
Oct 8, 2019
ppisljar
left a comment
Contributor
There was a problem hiding this comment.
there are still around 20 any types, please update those but apart from that code LGTM
Contributor
💚 Build Succeeded |
gospodarsky
pushed a commit
that referenced
this pull request
Oct 9, 2019
* Migrate url.js to TS * Typescriptify truncate util * Typescriptify string util * Change method name by constant * Typescriptify relative date util * Refactor url util * Typescriptify percent util * Typescriptify bytes util * Typescriptify number util * Make _convert as method of derived class * Get rid of Field Format type * Typescriptify IP and Color utils * Typescriptify dates utils * Change functions to arrow functions in tests * Convert Duration, Source and Static Lookup to TS * Remove Field Format type from Numeral * Use MomentJS types instead of any * Use KBN_FIELD_TYPES as field types * Make timezone as string * Make memoizedConverter and memoizedPattern types * Make ugly type for createNumberFormat * Replace any types by certain ones * Add types to tests * Internationalize Duration, String, Url utils * Get rid of implicit _convert method * Fix conflicts * Make htmlConvert, textConvert and setupContentType as public * Make some any's more certain
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
* Migrate url.js to TS * Typescriptify truncate util * Typescriptify string util * Change method name by constant * Typescriptify relative date util * Refactor url util * Typescriptify percent util * Typescriptify bytes util * Typescriptify number util * Make _convert as method of derived class * Get rid of Field Format type * Typescriptify IP and Color utils * Typescriptify dates utils * Change functions to arrow functions in tests * Convert Duration, Source and Static Lookup to TS * Remove Field Format type from Numeral * Use MomentJS types instead of any * Use KBN_FIELD_TYPES as field types * Make timezone as string * Make memoizedConverter and memoizedPattern types * Make ugly type for createNumberFormat * Replace any types by certain ones * Add types to tests * Internationalize Duration, String, Url utils * Get rid of implicit _convert method * Fix conflicts * Make htmlConvert, textConvert and setupContentType as public * Make some any's more certain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A part of #44973
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers