Repository navigation
[Maps] provide isLoading and hasError feedback when legend is collapsed - #47157
Merged
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
💚 Build Succeeded |
spong
approved these changes
Oct 2, 2019
spong
left a comment
Member
There was a problem hiding this comment.
Checked out, tested locally and all loading states look good in the SIEM app. LGTM 👍
Let's make sure we don't close #43695 though, as that request is specific to knowing when an embeddable is/isn't loading, which is functionality that we'll still need out of embeddables (e.g. to enable/disable our global refresh button when components are still loading). It's being tracked by the platform team as part of #43879.
kindsun
approved these changes
Oct 3, 2019
kindsun
left a comment
Contributor
There was a problem hiding this comment.
Very nice. Nicely handles prioritizing the loading state over the error state so you can still see if other layers are loading before it falls back to the error icon when complete.
- code review
- tested locally in chrome
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 3, 2019
nreese
added a commit
that referenced
this pull request
Oct 3, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #43695
There is not feedback for users when layers are loading or when layers have errors when the legend is collapsed. This PR changes the collapsed legend icon to a loading icon or alert icon when layers are loading or layers have errors.
To test, open any sample data map, collapse the legend, then click the
Refreshbutton.