Skip to content

[ML] Fixes reselection of same Anomaly Explorer swimlane cell - #48626

Merged
peteharverson merged 1 commit into
elastic:masterfrom
peteharverson:ml-swimlane-reselect
Oct 18, 2019
Merged

[ML] Fixes reselection of same Anomaly Explorer swimlane cell#48626
peteharverson merged 1 commit into
elastic:masterfrom
peteharverson:ml-swimlane-reselect

Conversation

@peteharverson

@peteharverson peteharverson commented Oct 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Fixes deselection / selection of cells in the Anomaly Explorer swimlane, where the charts and table would fail to update in the following use cases:

  • Select a cell
  • Deselect the cell by clicking on it again
  • Reselect the cell by clicking on it one more time

and

  • Select a cell
  • Deselect the cell by clicking next to a swimlane label
  • Reselect the same cell by clicking on again

explorer_swimlane_reselect

Checklist

For maintainers

Fixes #46222

@peteharverson
peteharverson requested a review from a team as a code owner October 18, 2019 10:38
@elasticmachine

elasticmachine commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic approved these changes Oct 18, 2019
View reviewed changes

@jgowdyelastic jgowdyelastic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine

elasticmachine commented Oct 18, 2019

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Oct 18, 2019
View reviewed changes

@walterra walterra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Oct 18, 2019
View reviewed changes

@alvarezmelissa87 alvarezmelissa87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@peteharverson
peteharverson merged commit 5988818 into elastic:master Oct 18, 2019
@peteharverson
peteharverson deleted the ml-swimlane-reselect branch October 18, 2019 14:28
@peteharverson peteharverson mentioned this pull request Oct 18, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Oct 18, 2019
@peteharverson
[ML] Fixes reselection of same Anomaly Explorer swimlane cell (elasti…
818ca11 
…c#48626)
peteharverson added a commit to peteharverson/kibana that referenced this pull request Oct 18, 2019
@peteharverson
[ML] Fixes reselection of same Anomaly Explorer swimlane cell (elasti…
8ccfaa0 
…c#48626)
@peteharverson peteharverson mentioned this pull request Oct 18, 2019
Merged
peteharverson added a commit that referenced this pull request Oct 21, 2019
@peteharverson
[ML] Fixes reselection of same Anomaly Explorer swimlane cell (#48626) (
d4f49d5 
#48652)
peteharverson added a commit that referenced this pull request Oct 21, 2019
@peteharverson
[ML] Fixes reselection of same Anomaly Explorer swimlane cell (#48626) (
bfd5411 
#48653)
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@peteharverson
[ML] Fixes reselection of same Anomaly Explorer swimlane cell (elasti…
d9d2bf4 
…c#48626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes
@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes
@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

No one assigned

Labels

Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.5.0 v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ML] Anomaly Explorer - tile selection / deselection doesn't always work

5 participants

@peteharverson @elasticmachine @walterra @alvarezmelissa87 @jgowdyelastic