Repository navigation
[SIEM] Fix AnomaliesNetworkTable and AnomaliesHostTable items count - #48634
Merged
patrykkopycinski merged 1 commit intoOct 18, 2019
Merged
patrykkopycinski merged 1 commit into
patrykkopycinski merged 1 commit into
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build Succeeded |
| totalItemCount: getSizeFromAnomalies(tableData), | ||
| initialPageIndex: 0, | ||
| initialPageSize: 10, | ||
| totalItemCount: hosts.length, |
Contributor
There was a problem hiding this comment.
Thanks for the extra fixes, I did accidentally use the incorrect props.
I confirmed these you changed them to are correct from EUI code base:
https://github.com/elastic/eui/blob/master/src/components/basic_table/in_memory_table.js#L67
And their docs:
You have a great 👁!
Contributor
|
I added the label of |
FrankHassanabad
approved these changes
Oct 18, 2019
FrankHassanabad
left a comment
Contributor
There was a problem hiding this comment.
Nice fix! Appreciate you finding the issue during testing and for looking deeper into the properties and fixing bugs associated with it.
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 19, 2019
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 19, 2019
patrykkopycinski
added a commit
that referenced
this pull request
Oct 19, 2019
patrykkopycinski
added a commit
that referenced
this pull request
Oct 19, 2019
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
totalItemCountwas counted improperly, because the number ofanomalies !== networks/hosts. For the pagination purpose let's use the size of thenetworks/hostsinsteadpageIndexandpageSizeare not supported, changed to the proper propertiesChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately