Skip to content

[Maps] Correctly open layer settings from add layer wizard - #48971

Merged
thomasneirynck merged 1 commit into
elastic:masterfrom
thomasneirynck:fix/open_layer_settings
Jan 24, 2020
Merged

thomasneirynck merged 1 commit into
elastic:masterfrom
thomasneirynck:fix/open_layer_settings

Conversation

@thomasneirynck

Copy link
Copy Markdown
Contributor

Closes #38990

This correctly removes the selection from the store-state, when opening the add-layer wizard.

@thomasneirynck thomasneirynck changed the title [Maps] Open layer settings from add [Maps] Correctly open layer settings from add layer wizard Oct 22, 2019
@thomasneirynck thomasneirynck added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Oct 22, 2019
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@nreese

nreese commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

There is no warning displayed about losing unsaved changes if the user edits the layer before clicking Add layer button

@nickpeihl nickpeihl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to suggestion by @nreese but otherwise, lgtm!

tested in chrome

@thomasneirynck
thomasneirynck force-pushed the fix/open_layer_settings branch from ca0e3b6 to 948758c Compare January 23, 2020 20:10
@thomasneirynck
thomasneirynck requested a review from a team as a code owner January 23, 2020 20:10
@thomasneirynck
thomasneirynck removed request for a team January 23, 2020 20:11
@thomasneirynck
thomasneirynck requested review from nreese and removed request for a team, nreese and watson January 23, 2020 20:11
@kibanamachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maps] Unable to open edit side bar with add layer side bar open

5 participants