Repository navigation
[SIEM] Add TLS to Network overview page - #48062
Conversation
ecac737 to
5aa3c40
Compare
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build Succeeded
|
5aa3c40 to
d33a69e
Compare
💔 Build Failed |
|
Right away, I think that you incorrectly resolved some conflicts. The Domains table was deleted from the repo in this PR #47608 Please ensure references to Domains are all removed |
💔 Build Failed |
💔 Build Failed |
|
You need to change |
|
Right now, the |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
| ...state, | ||
| [NetworkType.details]: { | ||
| ...state[NetworkType.details], | ||
| [networkType]: { |
There was a problem hiding this comment.
I got type errors and had to do the specific check like you see in updateTopNFlowLimit. have you run a type check here, trying to run it locally and its blowing up
| ); | ||
| }; | ||
|
|
||
| export const tlsSelector = (networkType: NetworkType) => { |
| export interface TlsRequestOptions extends RequestOptionsPaginated { | ||
| ip?: string; | ||
| tlsSortField: TlsSortField; | ||
| flowTarget: FlowTarget; |
There was a problem hiding this comment.
Should this be FlowTargetSourceDest?
| endDate={to} | ||
| filterQuery={filterQuery} | ||
| flowTarget={flowTarget} | ||
| flowTarget={FlowTargetSourceDest.source} |
There was a problem hiding this comment.
this does not need to be dynamic?
stephmilovic
left a comment
There was a problem hiding this comment.
Performed code review, ran locally, tested manually for quite a while between the different pages, activePage, limit, and sort. Everything is running smoothly. LGTM 🚀
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
|
jenkins, retest |
|
jenkins, test this |
💚 Build Succeeded |
💚 Build Succeeded |
* add TLS table to network overview page * isolate TLS parser * add unit test * add integration test * fix types * revert not necessary change * remove variables for domains table * fix for review * fix tlsSelector * update tls selector * apply updateTlsLimit * update selected property for tls selector * add networkType as the 2nd param of updateTlsSort * correcting pagetype * check the page type for updateTableActivePage * hard coded the targeting table name * remove tls table param as property * fix types
* add TLS table to network overview page * isolate TLS parser * add unit test * add integration test * fix types * revert not necessary change * remove variables for domains table * fix for review * fix tlsSelector * update tls selector * apply updateTlsLimit * update selected property for tls selector * add networkType as the 2nd param of updateTlsSort * correcting pagetype * check the page type for updateTableActivePage * hard coded the targeting table name * remove tls table param as property * fix types
💔 Build Failed |
* add TLS table to network overview page * isolate TLS parser * add unit test * add integration test * fix types * revert not necessary change * remove variables for domains table * fix for review * fix tlsSelector * update tls selector * apply updateTlsLimit * update selected property for tls selector * add networkType as the 2nd param of updateTlsSort * correcting pagetype * check the page type for updateTableActivePage * hard coded the targeting table name * remove tls table param as property * fix types
Summary
Isolating the existing TLS table from ip details page and share it with network overview page.
#47581
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately