Repository navigation
[Metrics UI] Tweak the z-index inventory toolbars - #49642
Conversation
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
This makes sense. I'm kind of confused about why any of these toolbars have a z-index. Seems that they're unnecessary. What happens if you just remove it? |
|
@phillipb there are elements below the toolbars that have high z-index values. If we remove the z-index those elements will be higher in the stack. Edit: funnily enough the high |
|
@afgomez is it just the tooltip that does that? If that's the case, IMO, that might be ok since it's a fringe scenario. Also, seems like we could just up the z-index of the popover menus since they already have one. Basically, just trying to avoid the extra cognitive overhead/maintenance of an extra prop here. @simianhacker might have some thoughts here too. |
💚 Build Succeeded
|
Having a z-index adds problems with the stacking of the dropdowns when there are two toolbars together.
645dee2 to
4ce76f5
Compare
💚 Build Succeeded |
|
Tested in all browsers (included IE11) without |
Having a z-index adds problems with the stacking of the dropdowns when there are two toolbars together.
Having a z-index adds problems with the stacking of the dropdowns when there are two toolbars together.
Having a z-index adds problems with the stacking of the dropdowns when there are two toolbars together.
Having a z-index adds problems with the stacking of the dropdowns when there are two toolbars together.
Fixes #49601.
Adds azIndexDiffattribute to the<Toolbar>component that allows the consumer to individually tweak thez-indexof each individual toolbar. By lowering the z-index attribute of the second toolbar, we prevent it from covering the dropdowns of the first oneRemoves the z-index of the
<Toolbar>to prevent stacking issues with the dropdowns of the different toolbars when there are two or more together.