[Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage by Zacqary · Pull Request #49781 · elastic/kibana

Zacqary · 2019-10-30T19:18:28Z

Summary

Goes back to using infrastructure and logs capabilities to determine whether their respective Settings pages should be editable, as opposed to logs determining it for both.

~~Waiting on issue discussion to determine if this is enough of a fix, or if the Settings Page needs some slight refactoring.~~

Also splits the Settings Page into two different pages, one displaying only Logs settings and one displaying only Metrics settings.

While we're at it, this also displays the "Loading Data Sources" prompt if the user deeplinks or refreshes directly to the Settings page; previously it would just display a blank page until data sources finished loading.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~[ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~[ ] Documentation was added for features that require explanation or tutorials~~
~~[ ] Unit or functional tests were updated or added to match the most common scenarios~~
~~[ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…Page

…pabilities-fix # Conflicts: # x-pack/legacy/plugins/infra/public/pages/logs/index.tsx

elasticmachine · 2019-10-30T19:18:30Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

elasticmachine · 2019-10-30T20:32:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 229471b

elasticmachine · 2019-10-31T19:34:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0dde711

Zacqary · 2019-11-07T15:20:02Z

@elasticmachine merge upstream

elasticmachine · 2019-11-07T16:36:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c94b1db

…pabilities-fix

…kibana into 48180-settings-capabilities-fix

elasticmachine · 2019-11-11T17:59:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f098e45

Zacqary · 2019-11-14T21:25:44Z

@elasticmachine merge upstream

elasticmachine · 2019-11-14T22:37:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7aceccc

Zacqary · 2019-11-18T15:46:28Z

@elasticmachine merge upstream

elasticmachine · 2019-11-18T17:06:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 791ff8e

weltenwort · 2019-12-02T11:00:41Z

@elasticmachine update branch

elasticmachine · 2019-12-02T12:11:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8522e94

weltenwort

This seems to work well, thank you!

weltenwort · 2019-12-02T12:27:29Z

-        helpText={
+    {displaySettings === 'metrics' && (
+      <EuiDescribedFormGroup
+        idAria="matricIndices"


This was incorrect before, but maybe we can use this opportunity to fix it:

Suggested change

idAria="matricIndices"

idAria="metricIndices"

weltenwort · 2020-01-03T18:41:42Z

Are we still planning to merge this?

…pabilities-fix # Conflicts: # x-pack/legacy/plugins/infra/public/components/source_configuration/fields_configuration_panel.tsx # x-pack/legacy/plugins/infra/public/components/source_configuration/indices_configuration_panel.tsx # x-pack/legacy/plugins/infra/public/pages/logs/index.tsx # x-pack/legacy/plugins/infra/public/pages/logs/settings.tsx

…kibana into 48180-settings-capabilities-fix

kibanamachine · 2020-01-08T19:43:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5ac3c14

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…Page (elastic#49781) * [Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage * Split settings pages in two; add loading screen to settings page * Restore timestamp field to metrics screen Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (23 commits) [Vis: Default editor] Reactify the timelion editor (elastic#52990) [Discover] fix histogram min interval (elastic#53979) [Telemetry] [Monitoring] Only retry fetching usage once monito… (elastic#54309) [docs][APM] Add runtime index config documentation (elastic#53907) [SIEM] Detection engine timeline (elastic#53783) Filter scripted fields preview field list to source fields (elastic#53826) Management - New platform api (elastic#52579) Reset region and Account when switching inventory (elastic#54287) [SIEM] [Case] Case workflow api schema (elastic#51535) Code coverage setup on CI (elastic#49003) [ML] DF Analytics Results: adds link to docs (elastic#54189) Update schemas boolean, byteSize, and duration to coerce strings (elastic#54177) [Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage (elastic#49781) [Canvas] Fixes bugs with autoplay and refresh (elastic#53149) [ML] DF Analytics Classification: ensure confusion matrix can be fetched (elastic#53629) Fix Vega react eslint errors (elastic#54259) Remove non existing codeowners (elastic#54274) use correct type (elastic#54244) [Dashboard] Removing 100% as dshDashboardViewport height (elastic#54263) add `examples/` to no-restricted-path config (elastic#54252) ...

…Page (#49781) (#54296) * [Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage * Split settings pages in two; add loading screen to settings page * Restore timestamp field to metrics screen Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…Page (elastic#49781) * [Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage * Split settings pages in two; add loading screen to settings page * Restore timestamp field to metrics screen Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Zacqary Xeper added 2 commits October 30, 2019 14:10

[Metrics UI] Pass relevant shouldAllowEdit capabilities into Settings…

95be4e8

…Page

Merge remote-tracking branch 'upstream/master' into 48180-settings-ca…

229471b

…pabilities-fix # Conflicts: # x-pack/legacy/plugins/infra/public/pages/logs/index.tsx

Zacqary added bug Fixes for quality problems that affect the customer experience v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 labels Oct 30, 2019

Zacqary requested a review from a team October 30, 2019 19:18

Split settings pages in two; add loading screen to settings page

0dde711

Zacqary marked this pull request as ready for review October 31, 2019 18:24

Zacqary added the release_note:fix label Oct 31, 2019

Merge branch 'master' into 48180-settings-capabilities-fix

c94b1db

Zacqary Xeper added 3 commits November 11, 2019 10:38

Merge remote-tracking branch 'upstream/master' into 48180-settings-ca…

f4c348a

…pabilities-fix

Merge branch '48180-settings-capabilities-fix' of github.com:Zacqary/…

5818a1e

…kibana into 48180-settings-capabilities-fix

Restore timestamp field to metrics screen

f098e45

Merge branch 'master' into 48180-settings-capabilities-fix

7aceccc

weltenwort requested review from weltenwort and removed request for weltenwort November 15, 2019 11:41

Merge branch 'master' into 48180-settings-capabilities-fix

791ff8e

Merge branch 'master' into 48180-settings-capabilities-fix

8522e94

weltenwort approved these changes Dec 2, 2019

View reviewed changes

Zacqary Xeper added 2 commits January 8, 2020 12:23

Merge branch '48180-settings-capabilities-fix' of github.com:Zacqary/…

5ac3c14

…kibana into 48180-settings-capabilities-fix

Zacqary merged commit 8edb53d into elastic:master Jan 8, 2020

Zacqary deleted the 48180-settings-capabilities-fix branch January 8, 2020 19:46

Zacqary mentioned this pull request Jan 8, 2020

[7.x] [Metrics UI] Pass relevant shouldAllowEdit capabilities into SettingsPage (#49781) #54296

Merged

Conversation

Zacqary commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 30, 2019

Uh oh!

elasticmachine commented Oct 30, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 31, 2019

💚 Build Succeeded

Uh oh!

Zacqary commented Nov 7, 2019

Uh oh!

elasticmachine commented Nov 7, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

Uh oh!

Zacqary commented Nov 14, 2019

Uh oh!

elasticmachine commented Nov 14, 2019

💚 Build Succeeded

Uh oh!

Zacqary commented Nov 18, 2019

Uh oh!

elasticmachine commented Nov 18, 2019

💚 Build Succeeded

Uh oh!

weltenwort commented Dec 2, 2019

Uh oh!

elasticmachine commented Dec 2, 2019

💚 Build Succeeded

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

weltenwort Dec 2, 2019

Choose a reason for hiding this comment

Uh oh!

weltenwort commented Jan 3, 2020

Uh oh!

kibanamachine commented Jan 8, 2020

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Zacqary commented Oct 30, 2019 •

edited

Loading