[Uptime] Issue/48845 Disable filter and Add link to location docs when no location exists by shahzad31 · Pull Request #49175 · elastic/kibana

shahzad31 · 2019-10-24T12:21:48Z

Summary

Disable Search Location filter and others if no searchable filter exists on them.
Also add link to location docs to guide user on how to add location for a heartbeat.

Checklist

This was checked for cross-browser compatibility, including a check against IE11
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-10-24T12:50:05Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2019-10-24T13:44:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: c67170a

elasticmachine · 2019-10-24T15:09:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2069973

justinkambic

These changes look good - assuming I understand the purpose of the patch. Is the goal to make it so that when there are no locations we supply the user with a link to the docs? The title of the PR is much different than that; I was initially confused as to why the popover's button was enabled.

If that's the case, can we rename the patch to something more like Link to Location docs when no location exists?

Aside from that I think the added code is ok, and I agree with disabling the field search when there're no items.

shahzad31 · 2019-10-25T15:06:24Z

These changes look good - assuming I understand the purpose of the patch. Is the goal to make it so that when there are no locations we supply the user with a link to the docs? The title of the PR is much different than that; I was initially confused as to why the popover's button was enabled.

If that's the case, can we rename the patch to something more like Link to Location docs when no location exists?

Aside from that I think the added code is ok, and I agree with disabling the field search when there're no items.

@justinkambic i have updated the title and description a bit.

justinkambic

LGTM

shahzad31 · 2019-10-28T10:29:12Z

@elasticmachine merge upstream

elasticmachine · 2019-10-28T11:51:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3d277d6

shahzad31 · 2019-10-28T15:41:49Z

@andrewvc @justinkambic should i backport this to 7.5 as well?

justinkambic · 2019-10-28T20:07:52Z

@shahzad31 yes this is a fix we should backport to the release branch as well.

…n no location exists (elastic#49175) * disable search text if no item exists * update snaps

…n no location exists (#49175) (#49903) * disable search text if no item exists * update snaps

…n no location exists (#49175) (#49902) * disable search text if no item exists * update snaps

shahzad31 · 2019-10-31T19:42:43Z

Back Ported to 7.x/7.6 and 7.5.

…n no location exists (elastic#49175) * disable search text if no item exists * update snaps

shahzad31 added 2 commits October 24, 2019 16:51

disable search text if no item exists

d477115

Merge branch 'master' into issue/48845--disable-empty-location-filter

c67170a

shahzad31 added release_note:fix v7.6.0 v8.0.0 labels Oct 24, 2019

shahzad31 requested a review from justinkambic October 24, 2019 12:49

shahzad31 self-assigned this Oct 24, 2019

shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 24, 2019

update snaps

2069973

justinkambic reviewed Oct 25, 2019

View reviewed changes

shahzad31 changed the title ~~[Uptime] Issue/48845 disable empty location filter~~ [Uptime] Issue/48845 disable location filter if no locations are present and add docs link to add location Oct 25, 2019

shahzad31 changed the title ~~[Uptime] Issue/48845 disable location filter if no locations are present and add docs link to add location~~ [Uptime] Issue/48845 Disable filter and Add link to location docs when no location exists Oct 25, 2019

justinkambic approved these changes Oct 25, 2019

View reviewed changes

Merge branch 'master' into issue/48845--disable-empty-location-filter

3d277d6

shahzad31 merged commit d9d8398 into elastic:master Oct 28, 2019

shahzad31 deleted the issue/48845--disable-empty-location-filter branch October 28, 2019 11:52

shahzad31 added the backport pending label Oct 28, 2019

shahzad31 added the v7.5.0 label Oct 28, 2019

This was referenced Oct 31, 2019

[7.x] [Uptime] Issue/48845 Disable filter and Add link to location docs when no location exists (#49175) #49902

Merged

[7.5] [Uptime] Issue/48845 Disable filter and Add link to location docs when no location exists (#49175) #49903

Merged

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 31, 2019

[Uptime] Issue/48845 Disable filter and Add link to location docs whe…

2d0a3cc

…n no location exists (elastic#49175) * disable search text if no item exists * update snaps

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 31, 2019

[Uptime] Issue/48845 Disable filter and Add link to location docs whe…

cf7fe27

…n no location exists (elastic#49175) * disable search text if no item exists * update snaps

shahzad31 added a commit that referenced this pull request Oct 31, 2019

[Uptime] Issue/48845 Disable filter and Add link to location docs whe…

bc77e71

…n no location exists (#49175) (#49903) * disable search text if no item exists * update snaps

shahzad31 added a commit that referenced this pull request Oct 31, 2019

[Uptime] Issue/48845 Disable filter and Add link to location docs whe…

818fa30

…n no location exists (#49175) (#49902) * disable search text if no item exists * update snaps

shahzad31 removed the backport pending label Oct 31, 2019

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026

[Uptime] Issue/48845 Disable filter and Add link to location docs whe…

64abdb2

…n no location exists (elastic#49175) * disable search text if no item exists * update snaps

Navigation Menu

Repository navigation

[Uptime] Issue/48845 Disable filter and Add link to location docs when no location exists - #49175

[Uptime] Issue/48845 Disable filter and Add link to location docs when no location exists#49175
shahzad31 merged 4 commits into
elastic:masterfrom
shahzad31:issue/48845--disable-empty-location-filter

shahzad31 commented Oct 24, 2019 •

edited

Loading

Uh oh!

elasticmachine commented Oct 24, 2019

Uh oh!

elasticmachine commented Oct 24, 2019

Uh oh!

elasticmachine commented Oct 24, 2019

Uh oh!

justinkambic left a comment

Uh oh!

shahzad31 commented Oct 25, 2019

Uh oh!

justinkambic left a comment

Uh oh!

shahzad31 commented Oct 28, 2019

Uh oh!

elasticmachine commented Oct 28, 2019

Uh oh!

shahzad31 commented Oct 28, 2019

Uh oh!

justinkambic commented Oct 28, 2019

Uh oh!

shahzad31 commented Oct 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shahzad31 commented Oct 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 24, 2019

Uh oh!

elasticmachine commented Oct 24, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 24, 2019

💚 Build Succeeded

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 commented Oct 25, 2019

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 commented Oct 28, 2019

Uh oh!

elasticmachine commented Oct 28, 2019

💚 Build Succeeded

Uh oh!

shahzad31 commented Oct 28, 2019

Uh oh!

justinkambic commented Oct 28, 2019

Uh oh!

shahzad31 commented Oct 31, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shahzad31 commented Oct 24, 2019 •

edited

Loading