Skip to content

Improve "Browser client is out of date" error message - #50296

Merged
sorenlouv merged 5 commits into
masterfrom
improve-error-message-for-kbn-version-mistmatch
Nov 16, 2019
Merged

sorenlouv merged 5 commits into
masterfrom
improve-error-message-for-kbn-version-mistmatch

Conversation

@sorenlouv

@sorenlouv sorenlouv commented Nov 12, 2019 •

Copy link
Copy Markdown
Contributor

Fixes: #6021

This doesn't make the message context dependent but provides some useful debugging information for the API usecase. It might not be super relevant for the browser usecase but I think the added value adds up for the slightly more verbose message.

@jalvz would this change make the error message clearer in your case?

@jalvz

jalvz commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

yep!

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@sorenlouv

Copy link
Copy Markdown
Contributor Author

retest

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

Comment thread src/legacy/server/http/version_check.js Outdated
Co-Authored-By: Josh Dover <me@joshdover.com>
@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@sorenlouv

Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@sorenlouv
sorenlouv removed the request for review from epixa November 14, 2019 13:37
@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine

Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@sorenlouv
sorenlouv merged commit 7b95f78 into master Nov 16, 2019
@sorenlouv
sorenlouv deleted the improve-error-message-for-kbn-version-mistmatch branch November 16, 2019 09:15
sorenlouv added a commit that referenced this pull request Nov 17, 2019
* improve "Browser client is out of date" error message

* Improve wording of error message

Co-Authored-By: Josh Dover <me@joshdover.com>

* Fox formatting

* Fix format
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 18, 2019
…her [skip ci]

* upstream/master: (54 commits)
  allows plugins to define validation schema for "enabled" flag (elastic#50286)
  Add retry to find.existsByDisplayedByCssSelector (elastic#48734)
  [i18n] integrate latest translations (elastic#50864)
  ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750)
  Fix @reach/router types (elastic#50863)
  [ML] Adding ML node warning to overview and analytics pages (elastic#50766)
  Bump storybook dependencies (elastic#50752)
  [APM Replace usage of idx with optional chaining (elastic#50849)
  [SIEM] Fix eslint errors (elastic#49713)
  Improve "Browser client is out of date" error message (elastic#50296)
  [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797)
  Move @kbn/es-query into data plugin - es-query folder (elastic#50182)
  Index Management new platform migration (elastic#49359)
  Increase retry for cloud snapshot to finish (elastic#50781)
  Removing EuiCode from inside EuiPanel (elastic#50683)
  [SIEM] Tests for search_after and bulk index (elastic#50129)
  Make babel understand TypeScript 3.7 syntax (elastic#50772)
  Fixing mocha tests and broken password change status codes (elastic#50704)
  [Canvas] Use compressed forms in sidebar (elastic#49419)
  Add labels to shell scripts in Jenkins (elastic#49657)
  ...
@dgieselaar

Copy link
Copy Markdown
Contributor

Removing the test plan label as this is a Kibana change, not an APM specific change and it's just a text update.

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
* improve "Browser client is out of date" error message

* Improve wording of error message

Co-Authored-By: Josh Dover <me@joshdover.com>

* Fox formatting

* Fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clearer error message for mismatched kbn-version on api request

6 participants